From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 88B412B9F5
	for <tarantool-patches@freelists.org>; Wed, 10 Apr 2019 20:24:37 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id pG8LQ7eJi79o for <tarantool-patches@freelists.org>;
	Wed, 10 Apr 2019 20:24:37 -0400 (EDT)
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 428152B9F0
	for <tarantool-patches@freelists.org>; Wed, 10 Apr 2019 20:24:37 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH v1 3/3] sql: remove unused functions
 from main.c
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <20190410073147.GJ8268@chai>
Date: Thu, 11 Apr 2019 03:24:31 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <74B61010-2EA1-4743-A9DE-F6F39F6265E2@tarantool.org>
References: <cover.1554830037.git.imeevma@gmail.com>
 <61b31e4086c3914a3b76683e531e1309a70cd291.1554830037.git.imeevma@gmail.com>
 <20190410073147.GJ8268@chai>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Konstantin Osipov <kostja@tarantool.org>, Imeev Mergen <imeevma@tarantool.org>



> On 10 Apr 2019, at 10:31, Konstantin Osipov <kostja@tarantool.org> =
wrote:
>=20
> * imeevma@tarantool.org <imeevma@tarantool.org> [19/04/09 20:19]:
>> -int
>> -sql_shutdown(void)
>=20
> This could be actually useful when debugging memory leaks, Nikita,
> what's your take?

I believe it is broken and useless. What is more, we are going
to completely remove SQLite's original allocators and use only
malloc and region. So, it makes no sense to leave this function.
If we may need to have smth like that someday, it will be easier
to implement it from scratch (IMHO).

>> -/*
>> - * Cause any pending operation to stop at its earliest opportunity.
>> - */
>> -void
>> -sql_interrupt(sql * db)
>> -{
>> -	db->u1.isInterrupted =3D 1;
>> -}
>=20
> This could also be useful.

TBO I don=E2=80=99t understand why it could be useful and how it can
be applied to our SQL implementation at all. Furthermore,
there=E2=80=99s no guarantee that we haven=E2=80=99t removed some parts
of this functionality during previous refactorings. Let=E2=80=99s finish =
it.