From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DB4E8445320
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 22 Jul 2020 01:43:36 +0300 (MSK)
References: <8c82ec8541391ee2558c51900af1525a8623ef6a.1593818521.git.v.shpilevoy@tarantool.org>
 <224d3b23-65b4-6533-6ac0-a040fc9b6af8@tarantool.org>
 <20200720222117.GC4221@grain> <20200721084515.GF4221@grain>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <73c7b227-18de-2043-1f21-fe8e3640d2ea@tarantool.org>
Date: Wed, 22 Jul 2020 00:43:35 +0200
MIME-Version: 1.0
In-Reply-To: <20200721084515.GF4221@grain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn: remove TXN_IS_DONE check
 from txn_commit()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tarantool-patches@dev.tarantool.org, sergos@tarantool.org

On 21.07.2020 10:45, Cyrill Gorcunov wrote:
> On Tue, Jul 21, 2020 at 01:21:17AM +0300, Cyrill Gorcunov wrote:
>> On Mon, Jul 20, 2020 at 10:24:01PM +0200, Vladislav Shpilevoy wrote:
>>> Still need somebody to take a look at this. It would
>>> help to make txn_commit more straightforward.
>>>
>>> Sergey Os.? Cyrill G. maybe?
>>
>> The idea looks reasonable. Could you please rebase the patch
>> on current master once time permit? This flag comes from the
>> series where I've been reworking journal engine hunting the
>> nil dereference in parallel applier code and after discussion
>> with KostyaO we choose to make helper functions which would
>> trigger error in case if async write is called from bootstrap
>> and recover code.
>>
>> Still removing code is always a good thing :-) I'll try to
>> rebase it myself tomorrow if you wont beat me on it today.
> 
> I've updated the patch locally. Vlad, lets postpone this
> particular patch -- I'm about to change journal code again
> for qsync reason and will grab your patch on top. Then will
> send it in the batch. Sounds ok?

I rebased the patch and added one more commit to make it work. See
the new email thread.