From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 407FC6F3C8; Wed, 21 Sep 2022 15:19:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 407FC6F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1663762783; bh=pMDovcS8uRg3nq8ANTMCWKNF4C1qaNwUkeVj6QH+kxE=; h=Date:In-Reply-To:To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RmOZ7hhzKT/oyjxfxqJzEqqbyIt/4mGweeEPGQtb9WyvoXrQS118QaTvRQBSj7NeU Q0cU4W9iQQ1+dfWkF1sMupK0zxijUW5pX8dk82raudOC5RNP58cOCSXiTI56YrLHnO DZNqQ/4ERMbzyM+l+3OCyp0Pw/KL2nUnahT/VpyQ= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8E23F6F3C8 for ; Wed, 21 Sep 2022 15:19:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E23F6F3C8 Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1oayhY-0003pt-O9; Wed, 21 Sep 2022 15:19:41 +0300 Message-Id: <7378A34A-6A2D-4634-B7A0-C9AA33267042@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_D53E8E8C-A8EA-4DFB-A82F-BE7C08AFB4E2" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Wed, 21 Sep 2022 15:19:40 +0300 In-Reply-To: To: Sergey Kaplun References: <20220912080158.12220-1-skaplun@tarantool.org> <1663573807.727706952@f769.i.mail.ru> <8E2BF2B3-C6BA-4F3E-A9AE-DA8F8413C4AF@tarantool.org> <1663667902.185627333@f160.i.mail.ru> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Mailru-Src: smtp X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9EBD81B01C038F8F3599E352275EC4F4D0235BE3157CE1562182A05F538085040B38C1F24FF388DC26D65D924C4F43A2A4A02158BCDDBC496BC10EDF8D3AB537E X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B01A5684911C72D27B4BE6EA2CDDC0A3E0076C844CED06872FA90933B19458B6299C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349DAEDEF7DE8FDCFAB3C82E2471A7BE3458B8E432E0628E7BA694BF764A623463B14DC687343F9D161D7E09C32AA3244C2FFC02B88F703DD5D4007CF191E84F735595C85A795C7BAEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojii4D+KDnlyppqlySh2LLBQ== X-Mailru-Sender: 11C2EC085EDE56FA38FD4C59F7EFE4073D4B372487BD00FCB67730529191D1D316E0CF1594CBD3C119381EE24192DF5555834048F03EF5D4C9A814A92B2E3B1BA4250FC3964EA4964198E0F3ECE9B5443453F38A29522196 X-Mras: OK Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Add tonumber() specialization for failed conversions. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: sergos via Tarantool-patches Reply-To: sergos Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_D53E8E8C-A8EA-4DFB-A82F-BE7C08AFB4E2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi! I see four =E2=80=98ok=E2=80=99s as a result of run.=20 See the full output for the run with dump() below: = s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/luajit/test/t= arantool-tests % ../../../../build-debug/src/tarantool -e = 'require"jit.dump".start("ib")' lj-408-tonumber-cdata-record.test.lua TAP version 13 1..4 ---- TRACE 1 start lj-408-tonumber-cdata-record.test.lua:17 0001 GGET 1 0 ; "tonumber" 0002 MOV 3 0 0003 CALL 1 2 2 0000 . FUNCC ; tonumber 0004 RET1 1 2 ---- TRACE 1 IR 0001 fun SLOAD #0 R 0002 tab FLOAD 0001 func.env 0003 int FLOAD 0002 tab.hmask 0004 > int EQ 0003 +63=20 0005 p64 FLOAD 0002 tab.node 0006 > p64 HREFK 0005 "tonumber" @8 0007 > fun HLOAD 0006 0008 > cdt SLOAD #2 T 0009 > fun EQ 0007 tonumber ---- TRACE 1 stop -> return ok - recorded with NULL and not converted for NULL ---- TRACE 2 start tap.lua:44 0001 TGETS 4 0 0 ; "total" 0002 ADDVN 4 4 0 ; 1 0003 TSETS 4 0 0 ; "total" 0004 GGET 4 1 ; "io" 0005 TGETS 4 4 2 ; "write" 0006 GGET 6 3 ; "string" 0007 TGETS 6 6 4 ; "rep" 0008 KSTR 8 5 ; " " 0009 TGETS 9 0 6 ; "level" 0010 MULNV 9 9 1 ; 4 0011 CALL 6 0 3 0000 . FUNCC ; string.rep 0012 CALLM 4 1 0 0000 . FUNCC ; io.write 0013 ISF 1 0014 JMP 4 =3D> 0025 0015 GGET 4 1 ; "io" 0016 TGETS 4 4 2 ; "write" 0017 GGET 6 3 ; "string" 0018 TGETS 6 6 7 ; "format" 0019 KSTR 8 8 ; "ok - %s\n" ---- TRACE 2 abort tap.lua:48 -- error thrown or hook called during = recording ok - recorded with NULL and converted for 0LL ---- TRACE flush ---- TRACE 1 start lj-408-tonumber-cdata-record.test.lua:17 0001 GGET 1 0 ; "tonumber" 0002 MOV 3 0 0003 CALL 1 2 2 0000 . FUNCC ; tonumber 0004 RET1 1 2 ---- TRACE 1 IR 0001 fun SLOAD #0 R 0002 tab FLOAD 0001 func.env 0003 int FLOAD 0002 tab.hmask 0004 > int EQ 0003 +63=20 0005 p64 FLOAD 0002 tab.node 0006 > p64 HREFK 0005 "tonumber" @8 0007 > fun HLOAD 0006 0008 > cdt SLOAD #2 T 0009 > fun EQ 0007 tonumber 0010 u16 FLOAD 0008 cdata.ctypeid 0011 > int EQ 0010 +11=20 0012 i64 FLOAD 0008 cdata.int64 0013 num CONV 0012 num.i64 ---- TRACE 1 stop -> return ok - recorded with 0LL and converted for 0LL ---- TRACE 2 start tap.lua:44 0001 TGETS 4 0 0 ; "total" 0002 ADDVN 4 4 0 ; 1 0003 TSETS 4 0 0 ; "total" 0004 GGET 4 1 ; "io" 0005 TGETS 4 4 2 ; "write" 0006 GGET 6 3 ; "string" 0007 TGETS 6 6 4 ; "rep" 0008 KSTR 8 5 ; " " 0009 TGETS 9 0 6 ; "level" 0010 MULNV 9 9 1 ; 4 0011 CALL 6 0 3 0000 . FUNCC ; string.rep 0012 CALLM 4 1 0 0000 . FUNCC ; io.write 0013 ISF 1 0014 JMP 4 =3D> 0025 0015 GGET 4 1 ; "io" 0016 TGETS 4 4 2 ; "write" 0017 GGET 6 3 ; "string" 0018 TGETS 6 6 7 ; "format" 0019 KSTR 8 8 ; "ok - %s\n" ---- TRACE 2 abort tap.lua:48 -- error thrown or hook called during = recording ok - recorded with 0LL and not converted for NULL ---- TRACE 2 start tarantool.lua:66 0016 UGET 2 1 ; fiber 0017 TGETS 2 2 4 ; "sleep" 0018 MOV 4 1 0019 CALL 2 1 2 0000 . FUNCC ; C:10b23f5e0 ---- TRACE 2 IR 0001 fun SLOAD #0 R 0002 > p64 UREFC 0001 #1 =20 0003 > tab ULOAD 0002 0004 int FLOAD 0003 tab.hmask 0005 > int EQ 0004 +31=20 0006 p64 FLOAD 0003 tab.node 0007 > p64 HREFK 0006 "sleep" @4 0008 > fun HLOAD 0007 0009 > num SLOAD #3 T 0010 > fun EQ 0008 C:10b23f5e0 ---- TRACE 2 stop -> stitch = s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/luajit/test/t= arantool-tests % git status HEAD detached at ae79d993 Untracked files: (use "git add ..." to include in what will be committed) ../../patch ../../src/lj_opt_narrow.c.orig ../../src/lj_opt_narrow.c.rej gh-6976-narrowing-of-unary-minus.test.lua lj-408-tonumber-cdata-record.test.lua nothing added to commit but untracked files present (use "git add" to = track) = s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/luajit/test/t= arantool-tests % git diff = s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/luajit/test/t= arantool-tests %=20 = s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/luajit/test/t= arantool-tests % git -C ../../../.. describe=20 2.11.0-entrypoint-494-gdc147ec91 > On 21 Sep 2022, at 15:03, Sergey Kaplun wrote: >=20 > Hi, Sergos! >=20 > Thanks for the review! >=20 > On 20.09.22, sergos wrote: >> First of all: >>=20 >> s.ostanevich@s-ostanevich2:~/workspaces/t.sergos % uname -a = =20 >> Darwin s-ostanevich2 21.6.0 Darwin Kernel Version 21.6.0: Mon = Aug 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64 >>=20 >> Then I just built Tarantool with ninja: >=20 > I tried run the test suite with ninja, but it's failed: > | $ ninja -C build tarantool-tests > | ... > | = /home/burii/builds_workspace/tarantool/master/third_party/luajit/test/tara= ntool-tests/lj-408.test.lua ......................................=20 > | not ok - recorded with NULL and converted for 0LL > | Dubious, test returned 1 (wstat 256, 0x100) > | Failed 1/4 subtests=20 > |... > | ninja: build stopped: subcommand failed. >=20 >>=20 >> Tarantool 2.11.0-entrypoint-494-gdc147ec91 >> Target: Darwin-x86_64-debug >>=20 >> Then I brought the test as a patch from the mail and run ninja test. >=20 > May you check the test output running without ninja like the follwing, > please: >=20 > | $ ../src/tarantool app-tap/lj-408-tonumber-cdata-record.test.lua=20 > | TAP version 13 > | 1..4 > | ok - recorded with NULL and not converted for NULL > | not ok - recorded with NULL and converted for 0LL > | --- > | filename: app-tap/lj-408-tonumber-cdata-record.test.lua > | line: 0 > | trace: > | - line: 0 > | source: '@app-tap/lj-408-tonumber-cdata-record.test.lua' > | filename: app-tap/lj-408-tonumber-cdata-record.test.lua > | what: main > | namewhat:=20 > | src: app-tap/lj-408-tonumber-cdata-record.test.lua > | ... > | ok - recorded with 0LL and converted for 0LL > | ok - recorded with 0LL and not converted for NULL > | # failed subtest: 1 >=20 > Also, please, check `jit.dump()` output. Maybe there is not trace for > some reason. > You can run the following command: > | $ ../src/tarantool -e 'require"jit.dump".start("ib")' = app-tap/lj-408-tonumber-cdata-record.test.lua >=20 > The start of output should be the following without the patch. >=20 > | 1..4 > | ---- TRACE 1 start lj-408-tonumber-cdata-record.test.lua:17 > | 0001 GGET 1 0 ; "tonumber" > | 0002 MOV 2 0 > | 0003 CALL 1 2 2 > | 0000 . FUNCC ; tonumber > | 0004 RET1 1 2 > | ---- TRACE 1 IR > | 0001 fun SLOAD #0 R > | 0002 tab FLOAD 0001 func.env > | 0003 int FLOAD 0002 tab.hmask > | 0004 > int EQ 0003 +63=20 > | 0005 p32 FLOAD 0002 tab.node > | 0006 > p32 HREFK 0005 "tonumber" @8 > | 0007 > fun HLOAD 0006 > | 0008 > cdt SLOAD #1 T > | 0009 > fun EQ 0007 tonumber > | ---- TRACE 1 stop -> return > | ... >=20 >>=20 >> The output says the test passes, while sources contains no patch. Am = I missing something? >>=20 >> Sergos >>=20 >=20 > >=20 >>>=20 >>=20 >=20 > --=20 > Best regards, > Sergey Kaplun --Apple-Mail=_D53E8E8C-A8EA-4DFB-A82F-BE7C08AFB4E2 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi!

I see = four =E2=80=98ok=E2=80=99s as a result of run. 
See the full output for the run with dump() below:


s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/lu= ajit/test/tarantool-tests % ../../../../build-debug/src/tarantool -e = 'require"jit.dump".start("ib")' = lj-408-tonumber-cdata-record.test.lua

TAP = version 13
1..4
---- = TRACE 1 start lj-408-tonumber-cdata-record.test.lua:17
0001  GGET     1   0      = ; "tonumber"
0002  MOV      3   = 0
0003  CALL     1   2 =   2
0000  . FUNCC       =         ; tonumber
0004  RET1     1   2
---- TRACE 1 IR
0001    fun SLOAD  #0  =   R
0002    tab FLOAD  0001  = func.env
0003    int FLOAD  0002  = tab.hmask
0004 >  int EQ     0003  = +63 
0005    p64 FLOAD  0002  = tab.node
0006 >  p64 HREFK  = 0005  "tonumber" = @8
0007 >  fun = HLOAD  0006
0008 = >  cdt = SLOAD  #2    T
0009 = >  fun EQ     0007  tonumber
---- = TRACE 1 stop -> return

ok - = recorded with NULL and not converted for NULL
---- TRACE 2 start tap.lua:44
0001  TGETS    4   0   0  ; = "total"
0002  ADDVN    4   4 =   0  ; 1
0003  TSETS    4   0   0  ; = "total"
0004  GGET     4   = 1      ; "io"
0005  TGETS    4   4   2  ; = "write"
0006  GGET     6   = 3      ; "string"
0007  TGETS    6   6   4  ; = "rep"
0008  KSTR     8   = 5      ; " "
0009  TGETS    9   0   6  ; = "level"
0010  MULNV    9   9 =   1  ; 4
0011  CALL     6   0   = 3
0000  . FUNCC       =         ; string.rep
0012  CALLM    4   1   = 0
0000  . FUNCC       =         ; io.write
0013  ISF          = 1
0014  JMP      4 = =3D> 0025
0015  GGET     4   1      = ; "io"
0016  TGETS    4   4 =   2  ; "write"
0017  GGET     6   3      = ; "string"
0018  TGETS    6   6 =   7  ; "format"
0019  KSTR     8   8      = ; "ok - %s\n"
---- = TRACE 2 abort tap.lua:48 -- error thrown or hook called during = recording

ok - = recorded with NULL and converted for 0LL
---- = TRACE flush

---- = TRACE 1 start lj-408-tonumber-cdata-record.test.lua:17
0001  GGET     1   0      = ; "tonumber"
0002  MOV      3   = 0
0003  CALL     1   2 =   2
0000  . FUNCC       =         ; tonumber
0004  RET1     1   2
---- TRACE 1 IR
0001    fun SLOAD  #0  =   R
0002    tab FLOAD  0001  = func.env
0003    int FLOAD  0002  = tab.hmask
0004 >  int EQ     0003  = +63 
0005    p64 FLOAD  0002  = tab.node
0006 >  p64 HREFK  = 0005  "tonumber" = @8
0007 >  fun = HLOAD  0006
0008 = >  cdt = SLOAD  #2    T
0009 = >  fun EQ     0007  tonumber
0010    u16 = FLOAD  0008  cdata.ctypeid
0011 = >  int EQ =     0010  +11 
0012    i64 = FLOAD  0008  cdata.int64
0013    num CONV =   0012  num.i64
---- TRACE 1 stop -> return

ok - recorded with 0LL and converted for 0LL
---- TRACE 2 start tap.lua:44
0001  TGETS    4   0   0  ; = "total"
0002  ADDVN    4   4 =   0  ; 1
0003  TSETS    4   0   0  ; = "total"
0004  GGET     4   = 1      ; "io"
0005  TGETS    4   4   2  ; = "write"
0006  GGET     6   = 3      ; "string"
0007  TGETS    6   6   4  ; = "rep"
0008  KSTR     8   = 5      ; " "
0009  TGETS    9   0   6  ; = "level"
0010  MULNV    9   9 =   1  ; 4
0011  CALL     6   0   = 3
0000  . FUNCC       =         ; string.rep
0012  CALLM    4   1   = 0
0000  . FUNCC       =         ; io.write
0013  ISF          = 1
0014  JMP      4 = =3D> 0025
0015  GGET     4   1      = ; "io"
0016  TGETS    4   4 =   2  ; "write"
0017  GGET     6   3      = ; "string"
0018  TGETS    6   6 =   7  ; "format"
0019  KSTR     8   8      = ; "ok - %s\n"
---- = TRACE 2 abort tap.lua:48 -- error thrown or hook called during = recording

ok - = recorded with 0LL and not converted for NULL
---- TRACE 2 start tarantool.lua:66
0016  UGET     2   1      = ; fiber
0017  TGETS    2   2 =   4  ; "sleep"
0018  MOV      4   = 1
0019  CALL     2   1 =   2
0000  . FUNCC       =         ; C:10b23f5e0
---- TRACE 2 IR
0001    fun SLOAD  #0  =   R
0002 >  p64 UREFC  = 0001  #1  
0003 = >  tab = ULOAD  0002
0004    int = FLOAD  0003  tab.hmask
0005 = >  int EQ =     0004  +31 
0006    p64 FLOAD  0003  = tab.node
0007 >  p64 HREFK  = 0006  "sleep" = @4
0008 >  fun = HLOAD  0007
0009 = >  num = SLOAD  #3    T
0010 = >  fun EQ     0008  C:10b23f5e0
---- = TRACE 2 stop -> stitch

s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/lu= ajit/test/tarantool-tests % git status
HEAD detached at ae79d993
Untracked= files:
  (use "git add <file>..." to = include in what will be committed)
= ../../patch
= ../../src/lj_opt_narrow.c.orig
= ../../src/lj_opt_narrow.c.rej
= gh-6976-narrowing-of-unary-minus.test.lua
= lj-408-tonumber-cdata-record.test.lua

nothing added to commit but untracked files present (use "git = add" to track)
s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/lu= ajit/test/tarantool-tests % git diff
s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/lu= ajit/test/tarantool-tests % 
s.ostanevich@s-ostanevich2:~/workspaces/t.sergos/third_party/lu= ajit/test/tarantool-tests % git -C ../../../.. = describe 
2.11.0-entrypoint-494-gdc147ec91



On 21 = Sep 2022, at 15:03, Sergey Kaplun <skaplun@tarantool.org> wrote:

Hi, = Sergos!

Thanks for the review!

On 20.09.22, sergos wrote:
First of all:

= s.ostanevich@s-ostanevich2:~/workspaces/t.sergos % uname -a =             &n= bsp;           &nbs= p;            =            
= Darwin s-ostanevich2 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug = 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64

Then I just built Tarantool with ninja:

I tried run the test suite with = ninja, but it's failed:
| $ ninja -C build = tarantool-tests
| ...
| = /home/burii/builds_workspace/tarantool/master/third_party/luajit/test/tara= ntool-tests/lj-408.test.lua ......................................
| not ok - recorded with NULL and converted for 0LL
| Dubious, test returned 1 (wstat 256, 0x100)
| = Failed 1/4 subtests
|...
| ninja: build = stopped: subcommand failed.


Tarantool = 2.11.0-entrypoint-494-gdc147ec91
Target: = Darwin-x86_64-debug

Then I brought the test = as a patch from the mail and run ninja test.

May you check the test output = running without ninja like the follwing,
please:

| $ ../src/tarantool = app-tap/lj-408-tonumber-cdata-record.test.lua
| TAP = version 13
| 1..4
| ok - recorded with NULL = and not converted for NULL
| not ok - recorded with NULL = and converted for 0LL
|   ---
| =   filename: app-tap/lj-408-tonumber-cdata-record.test.lua
|   line: 0
|   trace:
|   - line: 0
| =     source: = '@app-tap/lj-408-tonumber-cdata-record.test.lua'
| =     filename: = app-tap/lj-408-tonumber-cdata-record.test.lua
| =     what: main
| =     namewhat:
| =     src: = app-tap/lj-408-tonumber-cdata-record.test.lua
| =   ...
| ok - recorded with 0LL and converted for = 0LL
| ok - recorded with 0LL and not converted for NULL
| # failed subtest: 1

Also, = please, check `jit.dump()` output. Maybe there is not trace for
some reason.
You can run the following = command:
| $ ../src/tarantool -e = 'require"jit.dump".start("ib")' = app-tap/lj-408-tonumber-cdata-record.test.lua

The start of output should be the following without the = patch.

| 1..4
| ---- TRACE 1 = start lj-408-tonumber-cdata-record.test.lua:17
| 0001 =  GGET     1   0 =      ; "tonumber"
| 0002 =  MOV      2   0
| = 0003  CALL     1   2   2
| 0000  . FUNCC =             &n= bsp; ; tonumber
| 0004  RET1 =     1   2
| ---- TRACE 1 = IR
| 0001    fun SLOAD  #0 =    R
| 0002    tab FLOAD =  0001  func.env
| 0003    int = FLOAD  0002  tab.hmask
| 0004 >  int EQ =     0003  +63
| 0005 =    p32 FLOAD  0002  tab.node
| = 0006 >  p32 HREFK  0005  "tonumber" @8
| = 0007 >  fun HLOAD  0006
| 0008 >  cdt = SLOAD  #1    T
| 0009 >  fun = EQ     0007  tonumber
| ---- = TRACE 1 stop -> return
| ...


The = output says the test passes, while sources contains no patch. Am I = missing something?

Sergos


<snipped>




--
Best regards,
Sergey = Kaplun

= --Apple-Mail=_D53E8E8C-A8EA-4DFB-A82F-BE7C08AFB4E2--