From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 075F26EC55; Thu, 29 Jul 2021 23:58:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 075F26EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627592297; bh=L/XotrerRqVM/ncRynqU8J1AuP3oAKFZzf+6EV/eeYQ=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zcbKLNRbv0yw5EhpAEucQD/PzPr6qJRoZxfpn3r3J8r6I8tZV1ofDq8NBLShSMOj6 H9XdTe8NbjaaEmkChpc3jiuGEkhZSc6JP0Ye7qXJSnbHh+Megs/7ghlfT2mKIVDX6m MXJ2El/U/+jCQIhdPyIi+XTNgeum3tNBaMxzlTDI= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 978C26EC55 for ; Thu, 29 Jul 2021 23:58:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 978C26EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m9D6d-0008N1-VL; Thu, 29 Jul 2021 23:58:16 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <8d3502b3cf8b1acbda0ecb76c03284c9edf2f76a.1627384910.git.imeevma@gmail.com> Message-ID: <73729bdb-97c9-4edc-079f-dd0f5a5caa71@tarantool.org> Date: Thu, 29 Jul 2021 22:58:15 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <8d3502b3cf8b1acbda0ecb76c03284c9edf2f76a.1627384910.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C354866C15C72ED952BE56FFA0EFAF5B8C182A05F538085040B07EDB46B468BD60F759FD9EEA10B3D21B8D6A62E6DDF74FE0E6C1ADB5B0B433 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063732727FD5A4355FD18638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85D68EA9DCE72CDB3E7D530E150E9B552117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A519DDC14DA49D6E5C1183CAD89BFD67C073DC5583DD47C369D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7536C62C4FBC402878410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AEC7C2AC3C44791D0BAEF0E92E9D1A8B566EB86363C1E8BDCE391470F2E015B6D42345A2D8EE47801D7E09C32AA3244C0B77D28C4256AE9A4A312C3C3CFBE42024AF4FAF06DA24FD729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPp/mPgZxawGgkUZhI7nguA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D271108340BB5DE4ADBAB1EA480066B733841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 2/3] sql: disallow explicit cast of VARBINARY to number X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Good job on the fixes! On 27.07.2021 13:31, Mergen Imeev via Tarantool-patches wrote: > Thank you for the review! My answers, diff and new patch below. > > On 26.07.2021 23:12, Vladislav Shpilevoy wrote: >> Thanks for the patch! >> >> See 3 comments below. >> >> On 21.07.2021 17:10, Mergen Imeev via Tarantool-patches wrote: >>> This patch removes explicit cast of VARBINARY values to numeric types. >>> >>> Part of #4470 >>> Closes #4772 >>> Closes #5852 >> >> 1. You might need to add a changelog file. >> > I added in next commit, however, if you find it too general please let me know. > I will make it more specific. Yes, it looks too vague, a user won't be able to understand anything when see it in the changelog. Lets add more specifics. That BOOL <-> numbers was banned, and VARBINARY <-> numbers. And mention the bug that "sometimes a string couldn't be cast to boolean even if it was a correct boolean". After that LGTM and you can send it to a next reviewer.