From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DD3CD2EE42 for ; Sat, 25 May 2019 05:25:38 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RV0M_J9YovLk for ; Sat, 25 May 2019 05:25:38 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9BDF82E63F for ; Sat, 25 May 2019 05:25:38 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 10/12] sql: remove field errCode from struct sql References: <1a6c14c7d0913a816a8b6280ddea742bd06903bd.1557056617.git.imeevma@gmail.com> <9C2127ED-1278-4240-804D-3C7ADDE9C4E3@tarantool.org> From: Imeev Mergen Message-ID: <732e6318-63a0-b736-7756-0eeddb1e5aab@tarantool.org> Date: Sat, 25 May 2019 12:25:36 +0300 MIME-Version: 1.0 In-Reply-To: <9C2127ED-1278-4240-804D-3C7ADDE9C4E3@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "n.pettik" , tarantool-patches@freelists.org On 5/15/19 4:32 PM, n.pettik wrote: > >> On 5 May 2019, at 15:17, imeevma@tarantool.org wrote: >> >> This field became unusued and should be removed. >> --- >> >> diff --git a/src/box/sql/main.c b/src/box/sql/main.c >> index a3c6aa1..155cbcc 100644 >> --- a/src/box/sql/main.c >> +++ b/src/box/sql/main.c >> @@ -568,22 +568,6 @@ sqlTempInMemory(const sql * db) >> } >> >> /* >> - * Return the most recent error code generated by an sql routine. If NULL is >> - * passed to this function, we assume a malloc() failed during sql_open(). >> - */ >> -int >> -sql_errcode(sql * db) > Still see several mentions of this function in comments. Fixed. >