From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 47A986EC5F; Mon, 19 Apr 2021 17:09:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47A986EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618841392; bh=i012YkXANGcH661Jy59sgWFxus0CzD7RIJVdwji3YQc=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Whx/AbFWT5mDcIw5V79Xn1wGzs1iwnjrIuYxveMBg9qm1U/GNQWp8u9qG3moIzSXs XZyJ/0W3ClRj0eUO9Wqst68IDSuGsnRSke03lnGvcz473FvnQe2L4VakkFQC455336 EoiE8xXvOEiRGfB1UTYxUJveDh9MeUkMFZqZ+558= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 68E8F6EC5F for ; Mon, 19 Apr 2021 17:09:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 68E8F6EC5F Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1lYUaz-0002Ln-IZ; Mon, 19 Apr 2021 17:09:49 +0300 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: <20210416182100.10115-1-skaplun@tarantool.org> Date: Mon, 19 Apr 2021 17:09:43 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <732C82FC-C86D-4051-81B8-B2B6B992CB6D@tarantool.org> References: <20210416182100.10115-1-skaplun@tarantool.org> To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E748013307ED7ECCBF4892260E197EB99ED8F182A05F53808504036A46A3F601EDA26900C1A8F26FD13DA137458E25839478DF7CB291A1EC50F6E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CD693CC314794D958638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2395ED48FD33F554EED99B210E742E6EDC5BC91295CC49E52D2E47CDBA5A96583C09775C1D3CA48CF7EF884183F8E4D67117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7A4F00A9E8C511CEB9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73557739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A51CD57B6B711C93558A300B2767794A30B0A216916EABE5E0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D71B56C992F8AF1981A897E98893F371FFD356F52CFF50619AC5334709ED719DFEDCCF4CFE96BD621D7E09C32AA3244C7C22E0D59A263EEF85D788157A46CD8463871F383B54D9B3FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojocJA+pXcDukSrdt6PJQhAQ== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81E5303B19D4916B49A8A451AFA43CF64DAEAD561A8984177CDAD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix directory detection in lua-Harness suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch!=20 Just couple nits, LGTM. Sergos > On 16 Apr 2021, at 21:21, Sergey Kaplun wrote: >=20 > <314-regex.t> uses `arg[0]:find'314'` to determine the name of the ^ A test ...=20 Perhaps it=E2=80=99s just me, but I had a hard time to get rid of = feeling I read a hypertext in plain format.=20 > directory where rx_* files are located. This leads to the test > failure, when lua-Harness suite run in the directory containing ^ a You do not refer to a particular directory here, rather say =E2=80=98consi= der it is run in a directory =E2=80=A6' > "314" in its name, because the found path doesn't contain the required > files. >=20 > This patch fixes directory name detection. >=20 > Follows up tarantool/tarantool#5844 > --- >=20 > I tested it locally on branch in directory containing "314" in the = name. > Also, I grepped the test suites with "find", "match", "sub" patterns, > but didn't see other places with such bug like that. >=20 > Branch: = https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-harness-314-f= ind-bug > Tarantool branch: = https://github.com/tarantool/tarantool/tree/skaplun/gh-noticket-harness-31= 4-find-bug >=20 > test/lua-Harness-tests/314-regex.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/test/lua-Harness-tests/314-regex.t = b/test/lua-Harness-tests/314-regex.t > index ad4554cd..58cdb66e 100755 > --- a/test/lua-Harness-tests/314-regex.t > +++ b/test/lua-Harness-tests/314-regex.t > @@ -164,7 +164,7 @@ local function split (line) > end >=20 > local test_number =3D 0 > -local dirname =3D arg[0]:sub(1, arg[0]:find'314' -1) > +local dirname =3D arg[0]:gsub('([^/]+)%.t$', '') > for _, filename in ipairs(test_files) do > local f, msg =3D io.open(dirname .. filename, 'r') > if f =3D=3D nil then > --=20 > 2.31.0 >=20