From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8E4CD6E459; Wed, 17 Nov 2021 01:09:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E4CD6E459 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1637100543; bh=Yn7cUZAXcEkGZf7ZAoHeEa4frykqq4TvJBUWLWm3BUA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=MLQBzPNQr4r5KqioY185eSPtddhY2GfDQeum2G+IXxpk4p8jwDV3HFb1t4++ZV0v5 N3ITMVeh2A+GHvHGr6rEzsUYUlvEjhR7C3+isxy3hlPfgCiI6YYuf5ZMqpxDodJEv9 vCex37YVPjKIy9BEplEVqfhjH5z8qXk1Sr17+x1k= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B43746DB3F for ; Wed, 17 Nov 2021 01:08:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B43746DB3F Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mn6d0-0006Pf-QX; Wed, 17 Nov 2021 01:08:35 +0300 Message-ID: <72d95f3e-6a6c-d067-ec7f-eeec60f62f1f@tarantool.org> Date: Tue, 16 Nov 2021 23:08:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9731B3922EC063979606882B41E0195F8B6D0E21E6E224E5100894C459B0CD1B98FCF38CA7D8155D132111E4D12E499604D3C8E3199F746EE45196DB1478570EB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE764C944B6AA401A18EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063768D6DD405B71470F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8505AC2B35B545A0F7AEB0228473931F7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505F4279711C3CC3D76536DB09B655E3529 X-C1DE0DAB: 0D63561A33F958A5DE842AE766D2A4040E0E0E87EE9BF9AE1659AAF9E830DC66D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7506FE1F977233B9BB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AF61ACC197BF517AD1F9F0E3E6FAE98F1A1C70EEC6A12811D663377D5BAC75629661BB4C9510FBD21D7E09C32AA3244C1126ED78D5BBBBF66CB7AAB69C5CB7D030452B15D76AEC14729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj81eoY04PbolJ3QTHVnBPhg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D155F71B22035DE795628C1AD749B7C7C3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 00/11] ER_READONLY reason X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Pushed to master. On 12.11.2021 00:54, Vladislav Shpilevoy via Tarantool-patches wrote: > Changes in v2: > - A lot of minor fixes in all the commits; > - libuuid is moved into libcore; > - ER_READONLY message got the same details as in the fields. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5568-err-readonly-reason > Issue: https://github.com/tarantool/tarantool/issues/5568 > > Vladislav Shpilevoy (11): > diag: return created error from diag_set() > uuid: move into libcore > error: introduce error_payload > error: move code to struct error from ClientError > error: use error_payload to store optional members > error: use error_payload in MessagePack codecs > error: use error_payload in Lua > luatest: copy config in cluster:build_server() > luatest: add new helpers for 'server' object > box: enrich ER_READONLY with new details > error: report ER_READONLY reason in message > > .../unreleased/gh-5568-readonly-reason.md | 4 + > extra/exports | 3 +- > src/CMakeLists.txt | 3 +- > src/box/applier.h | 2 +- > src/box/bind.h | 2 +- > src/box/box.cc | 69 ++- > src/box/errcode.h | 2 +- > src/box/error.cc | 57 +-- > src/box/error.h | 60 +-- > src/box/field_def.c | 4 +- > src/box/index.cc | 4 +- > src/box/lua/serialize_lua.c | 2 +- > src/box/mp_error.cc | 197 +++----- > src/box/msgpack.c | 2 +- > src/box/replication.h | 2 +- > src/box/sql/mem.c | 2 +- > src/box/sql/mem.h | 2 +- > src/box/tuple.h | 2 +- > src/box/tuple_compare.cc | 8 +- > src/box/xlog.h | 2 +- > src/box/xrow.h | 2 +- > src/lib/CMakeLists.txt | 1 - > src/lib/core/CMakeLists.txt | 3 + > src/lib/core/crash.c | 2 +- > src/lib/core/diag.c | 37 +- > src/lib/core/diag.h | 109 +++- > src/lib/core/error_payload.c | 301 +++++++++++ > src/lib/core/error_payload.h | 190 +++++++ > src/lib/core/exception.cc | 8 +- > src/lib/core/exception.h | 66 +++ > src/lib/{uuid => core}/mp_uuid.c | 0 > src/lib/{uuid => core}/mp_uuid.h | 0 > src/lib/{uuid => core}/tt_uuid.c | 0 > src/lib/{uuid => core}/tt_uuid.h | 0 > src/lib/mpstream/CMakeLists.txt | 2 +- > src/lib/mpstream/mpstream.c | 2 +- > src/lib/swim/CMakeLists.txt | 2 +- > src/lib/swim/swim_io.h | 2 +- > src/lib/swim/swim_proto.h | 2 +- > src/lib/uuid/CMakeLists.txt | 2 - > src/lua/error.lua | 84 ++-- > src/lua/init.lua | 24 - > src/lua/msgpack.c | 6 +- > src/lua/tnt_msgpuck.h | 2 +- > src/lua/utils.c | 2 +- > test/box/error.result | 4 +- > test/box/error.test.lua | 2 +- > test/engine/func_index.result | 3 +- > test/luatest_helpers/cluster.lua | 1 + > test/luatest_helpers/server.lua | 66 ++- > .../gh_5568_read_only_reason_test.lua | 304 ++++++++++++ > test/replication/anon.result | 6 +- > test/replication/catch.result | 4 +- > test/replication/election_qsync.result | 11 +- > test/replication/election_qsync.test.lua | 4 +- > .../gh-6034-qsync-limbo-ownership.result | 22 +- > .../gh-6034-qsync-limbo-ownership.test.lua | 8 +- > test/sql-tap/CMakeLists.txt | 2 +- > test/sql-tap/gh-6024-funcs-return-bin.c | 2 +- > test/sql-tap/sql_uuid.c | 2 +- > test/unit/CMakeLists.txt | 4 +- > test/unit/error.c | 466 ++++++++++++++++++ > test/unit/error.result | 161 ++++++ > test/unit/mp_error.cc | 76 ++- > test/unit/mp_error.result | 27 +- > test/unit/swim_proto.c | 2 +- > test/unit/swim_test_utils.c | 2 +- > test/unit/swim_test_utils.h | 2 +- > test/unit/uuid.c | 4 +- > test/unit/vy_iterators_helper.c | 2 +- > test/unit/xrow.cc | 2 +- > test/vinyl/misc.result | 2 +- > third_party/lua-cjson/lua_cjson.c | 2 +- > third_party/lua-yaml/lyaml.cc | 2 +- > 74 files changed, 2069 insertions(+), 404 deletions(-) > create mode 100644 changelogs/unreleased/gh-5568-readonly-reason.md > create mode 100644 src/lib/core/error_payload.c > create mode 100644 src/lib/core/error_payload.h > rename src/lib/{uuid => core}/mp_uuid.c (100%) > rename src/lib/{uuid => core}/mp_uuid.h (100%) > rename src/lib/{uuid => core}/tt_uuid.c (100%) > rename src/lib/{uuid => core}/tt_uuid.h (100%) > delete mode 100644 src/lib/uuid/CMakeLists.txt > create mode 100644 test/replication-luatest/gh_5568_read_only_reason_test.lua > create mode 100644 test/unit/error.c > create mode 100644 test/unit/error.result >