From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D3AFF2B90F
	for <tarantool-patches@freelists.org>; Mon, 29 Apr 2019 07:07:45 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id vwzboljeWat7 for <tarantool-patches@freelists.org>;
	Mon, 29 Apr 2019 07:07:45 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8BC9D22A59
	for <tarantool-patches@freelists.org>; Mon, 29 Apr 2019 07:07:45 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 3/3] crypto: implement crypto codec
 API and AES 128 encryption
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
References: <cover.1556226152.git.v.shpilevoy@tarantool.org>
 <0e95f1eff6e2caaab4a2ed344bfdf9e67a9f23b5.1556226152.git.v.shpilevoy@tarantool.org>
Message-ID: <72a8abe6-39fb-7ec1-1abf-5ba9cf13ee6c@tarantool.org>
Date: Mon, 29 Apr 2019 14:07:42 +0300
MIME-Version: 1.0
In-Reply-To: <0e95f1eff6e2caaab4a2ed344bfdf9e67a9f23b5.1556226152.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: kostja@tarantool.org

I've decided that the patch is too raw and reworked it a bit.
I force pushed my changed resent the whole patchset in a new
thread as V2.

Main change is addition of a second encryption algorithm - None.
It is needed because SWIM has encryption API like

    swim_set_codec(enum crypto_algo algo, const char *key);

And I need a way how to disable encryption after its enabling.
It can be done now via

    swim_set_codec(CRYPTO_NONE, NULLL);


Secondly, I renamed 'encode/decode' to 'encrypt/decrypt' in
all methods and tests.

Thirdly, I removed hardcoded block sizes from encrypt() method.