From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E955156CD16; Wed, 7 Feb 2024 10:51:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E955156CD16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707292277; bh=3uC5XujLunA6gp8haXkABLok+g/8KQUFtzyLJj1On4k=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wwJyvDwsKmvLgAFCvB9wGu2fZ8ShoEWNtTzi0OLRBikzYTA2Vpw/jPnJtTrFQwAqG rEkvsuJdEiMjVb0MnGquB9U+cMGtcMSR5JFNIyHk7lQiBFHIYXDnUyntQG1rNOuNZn FyHDagv7OYEUStMdm+ZI5nvfP2rJ44yFHtQp/zy8= Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [95.163.41.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 885E956CD16 for ; Wed, 7 Feb 2024 10:51:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 885E956CD16 Received: by smtp39.i.mail.ru with esmtpa (envelope-from ) id 1rXci9-00000000QaU-3goo; Wed, 07 Feb 2024 10:51:14 +0300 Message-ID: <72a5dce8-d6d7-4c65-97a9-bc75cce4e720@tarantool.org> Date: Wed, 7 Feb 2024 10:51:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51C23E432171C17243CB97403412A6CD80182A05F538085040B343550C54D2494B3DE06ABAFEAF6705482A604CE3CC26D93BADE288438FC385106F9462B0A16F6A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7682AC3CFDB0E5E4FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373BFF7CCD9F2968778638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C7CCFA94CE23E8A1166FD589FC9948F5000A857C32D4B2D3CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063741880789376DFC6ED81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7541FADD3D81556A7EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5278DA827A17800CE7A03E8F3C2D3812562EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7C7AF014947417506731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5A26B0A20A28F9D485002B1117B3ED6960BB619CA770CCED69E040399BDE4761E823CB91A9FED034534781492E4B8EEAD11471C67CF6D96D5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFE3C4C36A5EC36E29810108A88E5974A3E20B512B5914295E0AF56E048C9E6043AFE07996864E0BE2807D692F32DC7032E03E37F761D133979A18118E20B80E12F61802CE78C59B265F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnMeCAgXyCaN6Q== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458CB8423087B611AF0D77739F4E260083EF5F61494303F78CAF0F7E6A595D4C1DC645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 17/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! much better now, thanks! LGTM On 2/6/24 16:58, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comments below. > > On 05.02.24, Sergey Bronnikov wrote: >> Hi, Sergey >> >> thanks for the patch! LGTM with minor comments >> >> On 1/29/24 13:45, Sergey Kaplun wrote: > > >>> -do >>> - assert(ffi.sizeof("foo1_t") == 12) >>> - local cd = ffi.new("foo1_t") >>> +do --- foo1_new_t >> test desc says nothing about what test tests. >> >> I would rename to something like "ffi.sizeof with custom struct" > Renamed as the following: > > =================================================================== > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_new.lua b/test/LuaJIT-tests/lib/ffi/ffi_new.lua > index 17578995..ec18e324 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_new.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_new.lua > @@ -10,7 +10,7 @@ void *malloc(size_t size); > void free(void *ptr); > ]]) > > -do --- new_foo1_t > +do --- ffi.sizeof with custom struct new_foo1_t > assert(ffi.sizeof("new_foo1_t") == 12) > local cd = ffi.new("new_foo1_t") > assert(ffi.sizeof(cd) == 12) > @@ -20,7 +20,7 @@ do --- new_foo1_t > assert(ffi.sizeof(cd) == 12) > end > > -do --- new_foo2_t > +do --- ffi.sizeof with custom struct new_foo2_t > assert(ffi.sizeof("new_foo2_t", 3) == 12) > local cd = ffi.new("new_foo2_t", 3) > assert(ffi.sizeof(cd) == 12) > @@ -57,14 +57,14 @@ do --- aligned structure GC > assert(nc < oc * 10, "GC step missing for ffi.new") > end > > -do --- VLA > +do --- VLA initialization > local t = {} > for i=1,100 do t[i] = ffi.new("int[?]", i) end > assert(ffi.sizeof(t[100]) == 400) > for i=0,99 do assert(t[100][i] == 0) end > end > > -do --- VLS > +do --- VLS initialization > local t = {} > local ct = ffi.typeof("struct { double x; int y[?];}") > for i=1,100 do t[i] = ct(i) end > =================================================================== > >> same below >> >>> + assert(ffi.sizeof("foo1_new_t") == 12) > > >>> jit_complex.lua