From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 570944696C3 for ; Wed, 15 Apr 2020 13:28:50 +0300 (MSK) From: Mons Anderson Message-Id: <72BDC386-AE45-4EDD-833F-E249DE3EB041@corp.mail.ru> Content-Type: multipart/alternative; boundary="Apple-Mail=_76F780C7-7BD6-4C8D-91DC-8C89442EB718" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Wed, 15 Apr 2020 13:28:48 +0300 In-Reply-To: <20200414204127.GA32171@atlas> References: <20200412113423.GA28681@atlas> <84069240-b5a4-9e61-09f4-a347fe53d54c@tarantool.org> <20200413094004.GB16266@atlas> <20200413094230.GC16266@atlas> <533bd68c-4bbb-446a-6265-da4f47d451f1@tarantool.org> <20200413194931.GB1734@tarantool.org> <8b7bcee8-b2db-8f2c-d241-687f6b6d6f4b@tarantool.org> <20200413213801.GB12552@atlas> <13d501d61286$af32d4b0$0d987e10$@tarantool.org> <20200414204127.GA32171@atlas> Subject: Re: [Tarantool-patches] [PATCH 00/43] Unhide symbols List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov Cc: tarantool-patches@dev.tarantool.org --Apple-Mail=_76F780C7-7BD6-4C8D-91DC-8C89442EB718 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 14 Apr 2020, at 23:41, Konstantin Osipov = wrote: >=20 > This is unrelated. 1.5 didn't have plugin api and no ffi exports=20 > and mons was hacking into it. >=20 > In fact he wasn't hacking into functions at all, he was hacking > into global state, such as cord_ptr->fiber, and it was not (and I > believe is not) removed from the visibility list by linker. >=20 > In short: > When trying to understand how this "feature" worked before, look > at 1.5, not 1.6+. You are wrong. It works in 1.6 and was broken by mejedi in the middle of = 1.7 and unfortunately left unseen For ex, I=E2=80=99m using in 1.6: ffi.cdef[[ uint32_t sc_version; ]] Things like that stop working after that patch. --=20 Mons Anderson Software Architect, Mail.Ru Cloud Solutions = --Apple-Mail=_76F780C7-7BD6-4C8D-91DC-8C89442EB718 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On = 14 Apr 2020, at 23:41, Konstantin Osipov <kostja.osipov@gmail.com> wrote:

This = is unrelated. 1.5 didn't have plugin api and no ffi exports
and mons was hacking into it.

In = fact he wasn't hacking into functions at all, he was hacking
into global state, such as cord_ptr->fiber, and it was not = (and I
believe is not) removed from the visibility list by = linker.

In short:
When trying = to understand how this "feature" worked before, look
at = 1.5, not 1.6+.

You are wrong. It works in 1.6 and was = broken by mejedi in the middle of 1.7 and unfortunately left unseen

For ex, I=E2=80=99m = using in 1.6:

ffi.cdef[[ uint32_t sc_version; ]]

Things like that stop = working after that patch.

-- 
Mons Anderson
Software = Architect, Mail.Ru Cloud = Solutions
<mons@cpan.org>

= --Apple-Mail=_76F780C7-7BD6-4C8D-91DC-8C89442EB718--