From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 223CE9A88EE; Mon, 5 Feb 2024 16:08:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 223CE9A88EE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707138519; bh=neDKdrBeFl5va4Ag1vLDciF6s62a185qr0vHK37w5xg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Qtkk97H6ZoCo/zWuENlUdHbCqLXmNxWI3j0bM4fW4fi07PqCz6NoJqsL9cztbRUS1 AINB4xXIs9mfQqAD/qFUhJ9atKJKrUFehtoDetTaWLjhFiNhRXGEmgwSAupvGUMAyE F3Hajw14umM8jSMHftsmIg5dEIdhqvIqB25c013M= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3C9DD9A88F5 for ; Mon, 5 Feb 2024 16:08:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3C9DD9A88F5 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1rWyiB-00000008FXd-3kKU; Mon, 05 Feb 2024 16:08:36 +0300 Message-ID: <72954849-cd6c-435d-a65d-d379674dabdc@tarantool.org> Date: Mon, 5 Feb 2024 16:08:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <2d1cb0d61396fbc7d6efd352ed540079df684477.1706520765.git.skaplun@tarantool.org> In-Reply-To: <2d1cb0d61396fbc7d6efd352ed540079df684477.1706520765.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51B9726ADA31168F4196B22ED51EBCAFDA182A05F53808504040A2CFB078D368EEC7A4B249DE6549FD024929D90A82B077434675A7731556E5E6CFE96EA49CC3A4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A609AE8E79ADB41CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637993F4D0874F024C68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86D666566395B176D46078C605226E07A8103FC256760C209CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C98E9388377045835C0837EA9F3D197644AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C33FBD1BE2333CCD82BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE7CD707F342D9BDC98731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5E76B04B7B881B6345002B1117B3ED696B7C9504D3DF3D09692212597CCBD6D77823CB91A9FED034534781492E4B8EEADBEC81E4AEBD6D2BFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF4135FA7F8A2A2D0BE100C9C77C2B8C12833AC888FEE5C67263DFA814CF8C493BD2D1C8B3CBCE0EE814BC176DD269F15EE5EE36A45F27B8DAE49A50F0E6955172C83AD304735402DD5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0TrRSEWQ3Vn9ga4pz9ohXA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769C46432B2BDA292C6C7A4B249DE6549FD024929D90A82B077B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 18/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for the patch! LGTM wit a minor comment On 1/29/24 13:45, Sergey Kaplun wrote: > This patch changes `dofile()` (which uses an unreliable relative file > path and mutates `_G` with global functions to be defined) to the > corresponding `require()` of the helper functions. It adds groups with > the names of subtests and enables the test in . > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua | 106 ++++++++++-------- > test/LuaJIT-tests/lib/ffi/index | 1 + > 2 files changed, 58 insertions(+), 49 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > index 3a9616d7..d3b02759 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > @@ -1,58 +1,66 @@ > local ffi = require("ffi") > > -do > +do --- sizeof VLA it is inconsistent with test name at least in a previous patch. Here: "sizeof VLA", in a previous patch "VLA". Feel free to ignore. > assert(ffi.sizeof("int [?]", 10) == 4*10) > local id = ffi.typeof("const short [?]") > assert(ffi.sizeof(id, 10) == 2*10) > @@ -64,7 +72,7 @@ do > assert(ffi.sizeof(id, 0x3fffffff) == 2*0x3fffffff) > end > > -do > +do --- sizeof VLS > assert(ffi.sizeof("struct { double x; int a[?]; }", 10) == 8+4*10) > local id = ffi.typeof("struct { int x; short a[?]; }") > assert(ffi.sizeof(id, 10) == 4+2*10) > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index > index e6c1fd0f..89773c0c 100644 > --- a/test/LuaJIT-tests/lib/ffi/index > +++ b/test/LuaJIT-tests/lib/ffi/index > @@ -16,6 +16,7 @@ ffi_jit_conv.lua > ffi_lex_number.lua > ffi_metatype.lua > ffi_new.lua > +ffi_parse_array.lua > istype.lua > jit_array.lua > jit_complex.lua