Thanks! LGTM On 1/3/26 09:28, Sergey Kaplun wrote: > Hi, Sergey! > Fixed your comment. > > On 02.01.26, Sergey Bronnikov wrote: >> Hi, Sergey! >> >> thanks for the patch! LGTM >> >> Sergey >> >> On 12/26/25 12:17, Sergey Kaplun wrote: > > >>> + payload = function() >>> + local wcode = [=[ >>> + return function(t, n) >>> + if n == 1 then return end >>> + local iubc, sub, write = iubc, string.sub, io.write >>> + local s = table.concat(t, "", 1, n - 1) >>> + for i = #s - 59, 1, -60 do >>> + write(]=] >>> + for i = 59, 3, -4 do >>> + wcode = wcode.."iubc[sub(s, i + "..(i - 3)..", i + "..i..")], " >>> + end >>> + wcode = wcode..[=["\n") >>> + end >>> + local r = #s % 60 >>> + if r ~= 0 then >>> + for i = r, 1, -4 do write(iubc[sub(s, i - 3 < 1 and 1 or i - 3, i)]) end >>> + write("\n") >>> + end >>> + end >>> + ]=] >> could you also apply the patch below with formatting? >> >> diff --git a/perf/LuaJIT-benches/revcomp.lua >> b/perf/LuaJIT-benches/revcomp.lua >> index 6e8a7049..9050110e 100644 >> --- a/perf/LuaJIT-benches/revcomp.lua >> +++ b/perf/LuaJIT-benches/revcomp.lua >> @@ -38,9 +38,9 @@bench:add({ >>        for i = #s - 59, 1, -60 do >>          write(]=] >>      for i = 59, 3, -4 do >> -      wcode = wcode.."iubc[sub(s, i + "..(i - 3)..", i + "..i..")], " >> +      wcode = wcode .. "iubc[sub(s, i + " .. (i - 3) .. ", i + " .. i >> .. ")], " >>      end >> -    wcode = wcode..[=["\n") >> +    wcode = wcode .. [=["\n") >>        end >>        local r = #s % 60 >>        if r ~= 0 then >> @@ -54,7 +54,10 @@bench:add({ >>      local t, n = {}, 1 >>      for line in io.lines() do >>        local c = sub(line, 1, 1) >> -      if c == ">" then writerev(t, n); io.write(line, "\n"); n = 1 >> +      if c == ">" then >> +        writerev(t, n); >> +        io.write(line, "\n"); >> +        n = 1 >>        elseif c ~= ";" then t[n] = line; n = n + 1 end >>      end >>      writerev(t, n) > Reformatted as you suggested: > > =================================================================== > diff --git a/perf/LuaJIT-benches/revcomp.lua b/perf/LuaJIT-benches/revcomp.lua > index 6e8a7049..1746334b 100644 > --- a/perf/LuaJIT-benches/revcomp.lua > +++ b/perf/LuaJIT-benches/revcomp.lua > @@ -18,7 +18,7 @@ iubc = setmetatable({ > t="A", g="C", v="B", h="D", m="K", y="R", u="A", > N="N", S="S", W="W", n="N", s="S", w="W", > }, { __index = function(t, s) > - local r = t[sub(s, 2)]..t[sub(s, 1, 1)]; t[s] = r; return r end }) > + local r = t[sub(s, 2)] .. t[sub(s, 1, 1)]; t[s] = r; return r end }) > > local stdout = io.output() > > @@ -38,9 +38,9 @@bench:add({ > for i = #s - 59, 1, -60 do > write(]=] > for i = 59, 3, -4 do > - wcode = wcode.."iubc[sub(s, i + "..(i - 3)..", i + "..i..")], " > + wcode = wcode .. "iubc[sub(s, i + " .. (i - 3) .. ", i + " .. i .. ")], " > end > - wcode = wcode..[=["\n") > + wcode = wcode .. [=["\n") > end > local r = #s % 60 > if r ~= 0 then > @@ -54,7 +54,10 @@bench:add({ > local t, n = {}, 1 > for line in io.lines() do > local c = sub(line, 1, 1) > - if c == ">" then writerev(t, n); io.write(line, "\n"); n = 1 > + if c == ">" then > + writerev(t, n) > + io.write(line, "\n") > + n = 1 > elseif c ~= ";" then t[n] = line; n = n + 1 end > end > writerev(t, n) > =================================================================== > >> >>> + local writerev = loadstring(wcode)() >>> + >>> + local t, n = {}, 1 >>> + for line in io.lines() do >>> + local c = sub(line, 1, 1) >>> + if c == ">" then writerev(t, n); io.write(line, "\n"); n = 1 >>> + elseif c ~= ";" then t[n] = line; n = n + 1 end >>> + end >>> + writerev(t, n) >>> + -- Repeat operation several times. >>> +io.stdin:seek("set", 0) >>> + end, >>> + teardown = function() >>> + io.output(stdout) >>> + end, >>> + -- Amount of symbols in the input file. >>> + items = 5e6, >>> +}) >>> >>> -local t, n = {}, 1 >>> -for line in io.lines() do >>> - local c = sub(line, 1, 1) >>> - if c == ">" then writerev(t, n); io.write(line, "\n"); n = 1 >>> - elseif c ~= ";" then t[n] = line; n = n + 1 end >>> -end >>> -writerev(t, n) >>> +bench:run_and_report()