From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 07D5F2504C for ; Thu, 21 Mar 2019 08:51:24 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jAHsd9YBtO3p for ; Thu, 21 Mar 2019 08:51:23 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6431525011 for ; Thu, 21 Mar 2019 08:51:23 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH 2/2] sql: don't change type of function's retval after codegen From: "n.pettik" In-Reply-To: Date: Thu, 21 Mar 2019 15:51:20 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <72283387-1BD8-420F-BBF7-8B516ADC1675@tarantool.org> References: <9a7a2794d68a949b801a3210231a35562fcf8847.1552327461.git.korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy > On 11/03/2019 21:10, Nikita Pettik wrote: >> Proper type of function's returning value is set during names = resolution >> (i.e. promotion from struct FuncDef to struct Expr, see >> resolveExprStep()). Accidentally, it was set again during byte-code >> generation for VDBE. What is more, in some cases it was set to a = wrong >> type. For instance, built-in function randomblob() returns value to = be >> encoded as MP_BIN, so its returning type is SCALAR. However, it was >> reset to INTEGER (as its first argument). This patch simply removes = this >> second type promotion. >> --- >> src/box/sql/expr.c | 11 ----------- >> test/sql/iproto.result | 41 = +++++++++++++++++++++++++++++++++++++++++ >> test/sql/iproto.test.lua | 15 +++++++++++++++ >> 3 files changed, 56 insertions(+), 11 deletions(-) >> diff --git a/test/sql/iproto.result b/test/sql/iproto.result >> index 3a77c8e93..26d55b60c 100644 >> --- a/test/sql/iproto.result >> +++ b/test/sql/iproto.result >> +-- Type set during compilation stage, and since min/max are accept >> +-- arguments of all scalar type, we can't say nothing more than >> +-- SCALAR. >> +-- >> +cn:execute("SELECT min(1, 2, 3);") >> +--- >> +- metadata: >> + - name: min(1, 2, 3) >> + type: scalar >=20 > This is the case, when a first argument type would be ok. As I > understand, it is illegal to calculate min of multiple different > types, so its rettype should be equal to its first argument. It > is not? Unfortunately, it is legal: tarantool> SELECT min('abc', 1); --- - - [1] =E2=80=A6 It is to be resolved in scope of this issue: https://github.com/tarantool/tarantool/issues/4032