From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 29AB16EC58; Sun, 1 Aug 2021 18:05:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 29AB16EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627830320; bh=yIQweNrlQxmTgKXyM9pVrnSWC+ES0NUkn77640DMMWI=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=qDUhrURP3yksLbdD4fd7P/2xgm9pc39kTsbw0xdWa7x9khH19GLYDAs7wqR8Xf6wg 9rMusRHIrTBd/99DStrHr7rVG2XfCw02IDbZUabSMTLvEyciN3i08T4a52jZrV3c5N 4QjZv+0ir66xRj5mBzlHJ2IkPlagdafJltTy9IEI= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4666A6EC5F for ; Sun, 1 Aug 2021 18:04:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4666A6EC5F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mAD0l-0000ri-IJ; Sun, 01 Aug 2021 18:04:19 +0300 To: Sergey Ostanevich References: <0deaaafed27a864820d91181c5d5f8c0c7bdcf70.1627420835.git.v.shpilevoy@tarantool.org> <55E403DE-9F49-42D5-9E9C-7B5207B17483@tarantool.org> Message-ID: <71afe341-9474-d053-e2f1-b694f5bc79a0@tarantool.org> Date: Sun, 1 Aug 2021 17:04:18 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <55E403DE-9F49-42D5-9E9C-7B5207B17483@tarantool.org> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C366EE405EC28A2001F8302D8429E0DE58182A05F53808504094270D79C483B6071DCEE1635F75655D3927D2F60FB3C67AA491E648F4C17FDC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76DA79C5AFF329FDBEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B3D04545C3E424F58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D897B5167377BF940D8D14B4DFB5487ED6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BF1175FABE1C0F9B6A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C565C1E6824D8037B43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5E4A962DBEDF3F5FC78E1113A75BE83698A447341FAE02FCDD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3450C5E6D685282BA143B2D2131FD2B76D9212D321E20DA5185B058FED91E068386C40BF3A41C3274B1D7E09C32AA3244C9012DD477110182D1BEF664597687E1FB4DF56057A86259FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMCfuYI4PreehxFjI3XljIw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D52104301233D541FB6AF2CA6D513DF263841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 5/5] decimal: introduce and use lua_pushdecimalstr() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the review! >> diff --git a/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >> index f806ba6b7..45273ed9a 100755 >> --- a/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >> +++ b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >> @@ -223,14 +224,50 @@ local function test_info_uuid(test) >>     test:ok(is_success, 'info uuid in gc') >> end >> >> +local function test_decimal(test) >> +    test:plan(1) >> + >> +    local gc_count = 100 >> +    local iter_count = 1000 >> +    local is_success = true >> + >> +    local d1 = decimal.new(1111111111111111111) >> +    local d2 = decimal.new(2222222222222222222) >> + >> +    local function decimal_to_str() >> +        local str1 = tostring(d1) >> +        local str2 = tostring(d2) >> +        local str3 = tostring(d1) >> +        local str4 = tostring(d2) >> +        if str1 ~= str3 or str2 ~= str4 then >> +            is_success = false >> +            assert(false) > > Same as previos patch with uuid. I refer to the > https://www.tarantool.io/en/doc/latest/reference/reference_lua/tap/#tap-example > perhaps I miss something? The assert is dropped on the branch.