From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AF6734696C3 for ; Sat, 11 Apr 2020 17:23:51 +0300 (MSK) References: <865fb768-3c90-ec8e-96cf-7d7598a9f6e0@tarantool.org> From: Vladislav Shpilevoy Message-ID: <711c06ec-7953-fcb0-f0cd-a1b68a37e8ae@tarantool.org> Date: Sat, 11 Apr 2020 16:23:49 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v3 0/2] Adapt luarocks for tarantoolctl List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yaroslav Dynnikov Cc: tarantool-patches@dev.tarantool.org > On 10/04/2020 19:02, Yaroslav Dynnikov wrote: > Hi, Leonid. > > The first patch ("Add the chdir option for make" 8e8db7f ) looks good to > me. I hope you'll be able to find time and propose it to upstream, in my > opinion it'll helpful there too. > > As of the second one ("Delete flags which can't be used with > tarantoolctl rocks" 1b51b2f ), I'm worried that our fork every day goes > farther from upstream. You didn't say a word about necessity to /remove/ > it, but it looks like another postponed problem. Leonid, btw, why do we remove them, again? I was always thinking it is a part of the ticket, but I don't see it there except in your comments. > Luarocks version is > already 3.3.1, while we still basing 3.1.1. And every such commit makes > it harder to rebase. > > The last time we were upgrading luarocks we've spent several weeks of > worktime to resolve all the problems. And, disappointingly, those > changes weren't merged to 1.10, so my colleagues usually come back with > the same problems as 2 years ago. Please, don't screw over our future > selves. While we sure should be as close to the upstream as possible, I think the rebase problem will appear always when you do any patches, and rebase once per 100 years.