From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8D8F56FC86; Sun, 25 Apr 2021 11:13:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8D8F56FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619338437; bh=uS6SDjSYBA0mv5bCILEBL1zYd7JTC2Qs0aczixE7APU=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nvLIsNtiBNlXt91TkXpRalIx87ijVARv+1pr1tCNE31aMDE5Z9syk0d0p01PKkKfN ttZEuDonG3lRNFVoM6774X5+GXrXzSJlK9sXGoh+OrNY5ExEnXggktYjLajV668bHd NaxQ9hsSTqOO6wsqkkMXzonukICtlka5XHva+5cw= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 388EA6FC86 for ; Sun, 25 Apr 2021 11:13:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 388EA6FC86 Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1laZts-00075V-Ag; Sun, 25 Apr 2021 11:13:56 +0300 To: Cyrill Gorcunov , tml References: <20210419083719.29689-1-gorcunov@gmail.com> <20210422113445.270688-1-gorcunov@gmail.com> Message-ID: <70a91c57-e0fb-6961-0e56-fddd5bbeea3a@tarantool.org> Date: Sun, 25 Apr 2021 11:13:55 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210422113445.270688-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9203E2ABA940B75486323DEBBB34FA34686FAAF51BCED67EE182A05F53808504063B2734CC2B8965ED584F26A0919887A9C9B072B4D9D48AD5E755154D1E17406 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A72B1EA4C8D5AD81EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF19945FAF91394A8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B276F422822B3D90A30FE658AB549A68834A8204C501E24153D2E47CDBA5A96583C09775C1D3CA48CFBCA4DA3BE1BC1572CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C000E2D00546020E658941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD2691661749BA6B97735670C872CCFE1D7AC7B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050FB28585415E75ADA9500AC0B2F9B62304B3661434B16C20AC78D18283394535A9E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BD9166E38712C78CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A57DA80D6289E63D577A801115140FAE751F055E88C1405DD8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341B5517184E88C1BD54BED29113FCC2C987CCDC9BBE2269A0F5F38DC9CABD6ADED064705A9C7B738F1D7E09C32AA3244CC3216B7CB5822F38E88320A9C979089B7C0C08F7987826B9927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj08M52wfuxcGkokqKAGWDZg== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F8D450BCAFC7226752A5F64E43DBB4308A041D7EBBE128562B424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 4/4] txn_limbo: simplify txn_limbo_on_parameters_change X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 22.04.2021 14:34, Cyrill Gorcunov пишет: > There is no need to test @confirm_lsn since we're > continue the list traversing in any case. > > I keep "continue" here to be consistent with other "if"s. > > Signed-off-by: Cyrill Gorcunov > --- > src/box/txn_limbo.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c > index 0ac8fff25..c07db3025 100644 > --- a/src/box/txn_limbo.c > +++ b/src/box/txn_limbo.c > @@ -707,8 +707,7 @@ txn_limbo_on_parameters_change(struct txn_limbo *limbo) > assert(e->ack_count <= VCLOCK_MAX); > if (!txn_has_flag(e->txn, TXN_WAIT_ACK)) { > assert(e->lsn == -1); > - if (confirm_lsn == -1) > - continue; > + continue; > } else if (e->ack_count < replication_synchro_quorum) { > continue; > } else { LGTM. -- Serge Petrenko