From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6D26123140 for ; Tue, 2 Jul 2019 19:27:15 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i7R4ZH7HlbgS for ; Tue, 2 Jul 2019 19:27:15 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 260102311B for ; Tue, 2 Jul 2019 19:27:15 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: [tarantool-patches] Re: [PATCH v2 3/3] sql: Fix destructors for constraints From: "n.pettik" In-Reply-To: <601cfb013ff3054f095261494fabcad0dc141246.1561720728.git.imeevma@gmail.com> Date: Wed, 3 Jul 2019 02:27:13 +0300 Content-Transfer-Encoding: 7bit Message-Id: <704322FB-2C57-4E8C-A3B3-7BF0CD2F3360@tarantool.org> References: <601cfb013ff3054f095261494fabcad0dc141246.1561720728.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen > On 28 Jun 2019, at 15:07, imeevma@tarantool.org wrote: > > Prior to this patch, the data needed to create the constraints in > VDBE was stored in the temporary registers of the parser. Since > this data is necessary for creating destructors, it was > transferred to standard registers. sql: use common registers instead of temp. for constraints data Prior to this patch, data needed to form tuple to be inserted to _fk_constraint and _ck_constraint system spaces (to create corresponding constraints) was stored in the range of temporary register. After insertion, temporary registers are released. On the other hand, this data is required for providing clean-up in case of creation fail (i.e. removing already created constraints within one CREATE TABLE statement). Hence, instead of using temporary registers let's use ordinary ones. Closes #4183