From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0900258123F; Wed, 16 Aug 2023 19:08:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0900258123F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692202135; bh=m+VbNbBvT/7dSV6C9/C7sAEiZDTZ7mV6SbQWLwiGW5A=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KQDDAP6/Ypk4eBJtIFEaKtGl1L49oKufM8FsMNDnkYMXFE9s7cKGHs6N1GgPh91T7 Q0ZGNPhD+zlFoRBKHCTXd4NDIkfAeu0lPQNGhpL05p8JewaoLrZMMl6fAgO9bU6e/X QmCzHQl8hWumNG7CtpcydhFWVyx+T8WWLD/sP8yU= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [95.163.41.91]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 32C40580F72 for ; Wed, 16 Aug 2023 19:08:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 32C40580F72 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1qWJ4m-00EsVW-0p; Wed, 16 Aug 2023 19:08:52 +0300 Message-ID: <703e04e9-b941-1f2c-5807-fc75e3bee739@tarantool.org> Date: Wed, 16 Aug 2023 19:08:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun References: <7179245cf38c56a88bb8f3aa1bbeaf15402fcd1a.1691592488.git.skaplun@tarantool.org> <7025f893-d2b0-2e78-faf4-22a98bdb7b3b@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D4D249011687940C6678A0DD020DA6E3B182A05F538085040774F38039BBC5BF1DA65F66BBF218A0BA23EB97E1DFA87D9A3114DBD27FD8210 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B264C8851FD8E810EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637826327602763C04B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D7BE0DF63E528F5FA2D5EF939CD71C07117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC07CB022245CAE856389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CAD0E433DBF1FBFA3040F9FF01DFDA4A84AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C319DD8FA685349A95BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166176DF2183F8FC7C0444A83B712AC0148725E5C173C3A84C309BC2A87FC68FC48089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: BCAA75B3C340DBBEEF3A853C90EA8D50F01536074D6990B7EE9D5CB6078CC77C3D7572025773D4C2EE319BF62A11F40A X-C1DE0DAB: 0D63561A33F958A58CF4D5ED0EC8411225BEFD20C8DC81139BBB080C10DF431BF87CCE6106E1FC07E67D4AC08A07B9B0E753FA5741D1AD02CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC71106E36FF2641B7B8424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D342C0B628602DFD0BC258658FF1EDA4442F26C6CA43C67A53D35BC43829FAEAA6ADA80FA6003DB5EA51D7E09C32AA3244CE5DBF2FD595324C0DA1042236FF9D7928894E9C85370243EBAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxrWgHak/HS5Nw== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458BDB188EC1BB87FC25A574A88AB7FC0CEF9EB359CAF6226B7282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 03/19] MIPS: Fix handling of spare long-range jump slots. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks! LGTM now On 8/16/23 18:32, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > > On 16.08.23, Sergey Bronnikov wrote: >> Hi, Sergey >> >> >> thanks for the patch! >> >> Test has passed after reverting a patch and I suspect it is expected because >> >> behaviour was broken for MIPS only, right? > Yes, its true. > >> See a minor comment below. >> >> >> On 8/9/23 18:35, Sergey Kaplun wrote: >>> From: Mike Pall >>> >>> Contributed by Djordje Kovacevic and Stefan Pejic. >>> >>> (cherry-picked from commit c7c3c4da432ddb543d4b0a9abbb245f11b26afd0) >>> >>> `asm_setup_jump()` in presumes that `sizeof(MCLink)` >>> is 8 bytes, but for MIPS64 its size is 16 bytes. This leads to incorrect >>> check in `asm_sparejump_setup()`, so mcode bottom is not updated. >>> >>> This patch fixes check of the MCLink offset from the mcbot. >>> Nevertheless, the emitting of spare jump slots is still incorrect, so >>> the introduced test still fails due to incorrect iteration through the >>> sparce table (the last slot is out of mcode range). >> "sparce" -> "sparse"? > Changed to the "spare slots". > >>