From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 785D7580F72; Wed, 16 Aug 2023 18:03:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 785D7580F72 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692198180; bh=mu7+9sfZaElPJm5CTTG8HUZdYnYjw1paaiwVb10hPNI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pPzoCIOpGXbzZ3gFDBQ7cuBWQ5D32Lt9S7BoA0CEoPnGPiEv0gnF8U3auERDVR5TD MKBWagB811iOHAWxixZg9tbM83vtVNJMUOKB9zYNdYpO4Ya+ojdh2x0NR5cpkn4mkZ xO9pP8BqcfFsggOG8EVzjRmbyJRJyNVRM+mfKjSw= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 03343532601 for ; Wed, 16 Aug 2023 18:02:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 03343532601 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1qWI2z-002Lko-2n; Wed, 16 Aug 2023 18:02:58 +0300 Message-ID: <7025f893-d2b0-2e78-faf4-22a98bdb7b3b@tarantool.org> Date: Wed, 16 Aug 2023 18:02:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun , Igor Munkin References: <7179245cf38c56a88bb8f3aa1bbeaf15402fcd1a.1691592488.git.skaplun@tarantool.org> In-Reply-To: <7179245cf38c56a88bb8f3aa1bbeaf15402fcd1a.1691592488.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D1399757346C038D9B2FE68E137CB1837182A05F5380850402EE8156F142C9518588CC643E1342852A232A5DD22DB28A09C5D95AC2BDFC29C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637968EC5F77C2942FE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C7E238BFB271ABD18C88D2E9DF002A0B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC6CE7A4E25BAF3B969FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF69B99345B4CD43D4BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B63271950E746CB25C76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB33AC447995A7AD18156CCFE7AF13BCA4D5E8D9A59859A8B6ACE00135B021D8CA089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A522D05B41025A56F15ECA47EA9140D33DCC8C7CF9C121AC2DF87CCE6106E1FC07E67D4AC08A07B9B02A336C6518635091CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D9DC20663B80603FFE78715FB862814F84BD9FD76C502B2F73242CB692AF277E276AC0ABEA14880B1D7E09C32AA3244C43A9F806D7D0421D39D1CAF2400F7A014DBEAD0ED6C55A80BAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVl7ekwB6hiVP/iSq5pz+Q== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458F9497AE55F1993986B6322C9FEE601B4772A25DE7238B651282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 03/19] MIPS: Fix handling of spare long-range jump slots. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for the patch! Test has passed after reverting a patch and I suspect it is expected because behaviour was broken for MIPS only, right? See a minor comment below. On 8/9/23 18:35, Sergey Kaplun wrote: > From: Mike Pall > > Contributed by Djordje Kovacevic and Stefan Pejic. > > (cherry-picked from commit c7c3c4da432ddb543d4b0a9abbb245f11b26afd0) > > `asm_setup_jump()` in presumes that `sizeof(MCLink)` > is 8 bytes, but for MIPS64 its size is 16 bytes. This leads to incorrect > check in `asm_sparejump_setup()`, so mcode bottom is not updated. > > This patch fixes check of the MCLink offset from the mcbot. > Nevertheless, the emitting of spare jump slots is still incorrect, so > the introduced test still fails due to incorrect iteration through the > sparce table (the last slot is out of mcode range). "sparce" -> "sparse"?