From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0A84FCAFDAD; Mon, 23 Sep 2024 09:41:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0A84FCAFDAD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1727073696; bh=IHjh5cxouV2HU3ouKScj3Ogl8VE8toWHPCdxVB2W+KU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pkME5OzWNGjMhK/2fzNfPWziOwq47UQvgzKHytAmOVLqpREEEMWZhCnsE7t+uxBXK ZlsZoRZgk9FKuqaRBzFdWf4HYqE25k0E5XV/N+BMO0a77/pLwosWFKLMUsWRn2a8XA Yb5URW3OhPo4pa5jkohd2MhrEWoQyfbXTHVA6o8Y= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [95.163.41.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DF0AA5874A1 for ; Mon, 23 Sep 2024 09:41:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DF0AA5874A1 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1ssclJ-0000000BTYY-2Gyw; Mon, 23 Sep 2024 09:41:34 +0300 Date: Mon, 23 Sep 2024 09:41:32 +0300 To: Sergey Kaplun Message-ID: <6xbb7bbda3bm7ryzzdovwq32wukphxi7aykr5wm3oxc3wsxxao@povjteevh5va> References: <20240826123740.12759-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826123740.12759-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96E52E9D942F25A5FE0F4C8AADDA49724D81F899678C50E6500894C459B0CD1B977BA8DE7D5D415BCE16836E22356ABE0333FDC3834CACFACB23E4D71B1159AC560DFE2D95CBACD2B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73870E1FF9A049D91EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375189E43B47FB350A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F2B0C1D6BB8BA7B9D17D60FCCFF23D23A9380CDEEC9FA3DACC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F409322A2F59C95CC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A54F8E8A2FBC4D68A65002B1117B3ED6966D1340DC2587A40930E4A65F242F5898823CB91A9FED034534781492E4B8EEADD0953842B444AAC3BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A5970F8A4685C8AB78AF3ED515BA69808A719C4876D975DC38B1D0E0CBBDC01A61C47B44A4C8E11F1D7E09C32AA3244C48E5C0181B14DB267B0DC8E7D22A103A5469A24DF159539DEA455F16B58544A2557BDE0DD54B3590965026E5D17F6739C77C69D99B9914278E50E1F0597A6FD5CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojcsBYxvRMKeyq2vaKRcbsGA== X-DA7885C5: 4117E44A38E6E7D4F255D290C0D534F97EE38C982534E11A5CEE7D516BF07378D5FC050E3C9F98DD5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B7079EDB9A368126A41DD6B021AF044C966DDC5322D0A446C563E610FBBDBB4C842051EA7CBBFB5097AB92FA4D94F20E3E33C1B503AADE26945BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix limit check in narrow_conv_backprop(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except for a few nits below. On Mon, Aug 26, 2024 at 03:37:40PM GMT, Sergey Kaplun wrote: > From: Mike Pall > > Thanks to Sergey Kaplun. > > (cherry picked from commit e45fd4cb713b610506213692f3b55a1869febb03) > > `narrow_conv_backprop()` misses the stack pointer (`nc->sp`) limit check > after a bunch of recursive calls that may change its value. As a result, It took me a minute to understand that sentence. Let's paraphrase it the following way: | The function narrow_conv_backprop() does not include a limit | check for the stack pointer (nc->sp), even though its value may | change after several recursive calls. > it leads to stack-buffer-overflow during the instruction narrowing. This > patch adds a missing check. Typo: s/a missing/the missing > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#10199 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1262-fix-limit-narrow-conv-backprop > Related issues: > * https://github.com/tarantool/tarantool/issues/10199 > * https://github.com/LuaJIT/LuaJIT/issues/1262