From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH 2/2] Move 'core' and 'uuid' libs to src/lib References: <20190226083033.GE2696@chai> <2f04d991-10c2-ba20-9624-8ae2cf425069@tarantool.org> <20190226102737.GA5592@chai> From: Vladislav Shpilevoy Message-ID: <6ffe2a55-93b8-faec-e164-64812ce66df9@tarantool.org> Date: Tue, 26 Feb 2019 15:11:55 +0300 MIME-Version: 1.0 In-Reply-To: <20190226102737.GA5592@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Konstantin Osipov Cc: tarantool-patches@freelists.org, vdavydov.dev@gmail.com List-ID: On 26/02/2019 13:27, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/02/26 12:41]: >> On 26/02/2019 11:30, Konstantin Osipov wrote: >>> * Vladislav Shpilevoy [19/02/26 00:59]: >>>> For the same reason why 'uri' was moved to src/lib - SWIM needs >>>> core and uuid, and SWIM will live in src/lib. >>>> >>>> This commit follows 'uri' relocation as a separate one because >>>> 'uri' relocation required some changes in the files, moved by >>>> this commit. >>> >>> The patch itself is looking good to me, it's a pity collation >>> library depends on the core, I would perhaps make it separate if >>> possible, but we're doing swim after all, right? >>> >>> The same applies to http parser. >> >> Citing your own words - you said, that we do not need to split >> libraries now. For SWIM it is enough to just move existing uri >> and core libraries into src/lib, without any changes inside the >> latter. >> >> But if you want to extract collation and http, I can do that. >> Should I? > > Up to you. If you find it easy to do (within 1 hour of your time > for each patch) - please don't postpone it. Done, see v2 thread. > > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >