From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 961AE4696C6 for ; Fri, 14 Feb 2020 00:54:42 +0300 (MSK) References: <20200213080646.10494-1-skaplun@tarantool.org> From: Vladislav Shpilevoy Message-ID: <6fb5e3e2-8da7-c6fa-029f-fc7c669d1d47@tarantool.org> Date: Thu, 13 Feb 2020 22:54:41 +0100 MIME-Version: 1.0 In-Reply-To: <20200213080646.10494-1-skaplun@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Kaplun , tarantool-patches@dev.tarantool.org Hi! Thanks for the patch! LGTM. On 13/02/2020 09:06, Sergey Kaplun wrote: > We already have 12Kb thread-safe static buffer > in `lib/small/small/static.h`, that can be used instead of 16Kb > bss buffer in `src/lib/core/backtrace.cc` for backtrace payload. > > Closes #4650 > --- > > branch: https://github.com/tarantool/tarantool/tree/skaplun/drop-bss-buff > issue: https://github.com/tarantool/tarantool/issues/4650 > > src/lib/core/backtrace.cc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)