From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 26DE070297; Fri, 3 Dec 2021 02:46:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 26DE070297 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638488800; bh=oiRwxtvN17MfDXQJ6gSOerFbHYQC4zKKCKeLpmrmcaU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AM1y0wj/T9eECwLk6Ej9rXyu96fj2TC7LxROK4NfPqlIyd02zNG6iiPNCbFSvUu75 0J4l1VgdeZmMYK5WWyrxx7AiqN6zO2nnUf+JMIwY5Xvyh1Cz3dEmLi2O/QuOXFajnH DnyOrVFn8TT6NGivwit9JL+NPxamt3KkhuDgDe0Y= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E41F670297 for ; Fri, 3 Dec 2021 02:46:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E41F670297 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1msvmd-00047n-9v; Fri, 03 Dec 2021 02:46:35 +0300 Message-ID: <6f9b09b0-65d2-2f81-8316-5f2940a35100@tarantool.org> Date: Fri, 3 Dec 2021 00:46:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Content-Language: en-US To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org References: <2746684244053070165bf106f754866fea02096e.1637756342.git.imeevma@gmail.com> <90cabda5-9596-010f-6351-6baf8ba24ef5@tarantool.org> <20211201075940.GA29482@tarantool.org> In-Reply-To: <20211201075940.GA29482@tarantool.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93822B471089FF64DFA455658C3104DE9A8FD3EA0957DD338182A05F538085040D1637A96D9FE6AEFEDE68AB497A941C1D4951F5C55C5B3074BC8B3C4D72B5031 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77BF46084C0059042EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637EF59B520676799BC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87988A1525AF2B03F91076672278329B5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE437C869540D2AB0F436E4CC186B5AB2DD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3568FCE88E0C8489DAD7EC71F1DB88427C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377AA2284B41911753EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A58CC8288FDA43EC22A6C0225AF304BF2175C310DE5CCA16D9D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7506FE1F977233B9BB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348CDF4129B2EA8560D32D1CE4CAFA7E611ABA7969418F3F809D3DA1E26E88CB8F7924A4F9F590DED01D7E09C32AA3244CE00C0313D362C2243E8F51BE25C787FF60759606DA2E136A729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMMFVqzO9sR2IyWp6pg9FiQ== X-Mailru-Sender: 1F3202E75A95DDEFB45532EB6DE299A6D4DB4C61DE0785DBE8A934614D69E9942ACEE04A2EFD022E07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 01.12.2021 08:59, Mergen Imeev via Tarantool-patches wrote: > Hi! Thank you for the review! My answer below. > > On Tue, Nov 30, 2021 at 10:00:44PM +0100, Vladislav Shpilevoy wrote: >> Hi! Thanks for the patch looks good, but I would drop this 'register trace' >> entirely. Everything that uses 'printf' is dead anyway. >> > I'm not sure about that. For example, I have executed these statements on master and on my branch: It is a misunderstanding. I didn't mean you patch does not change anything. I meant that this whole mechanism of 'register traces' is dead IMO. It is unusable. For example, if you need to debug something on a remote server, you won't see these printf() results anyway. Because you perhaps will talk to the server using IProto. So whatever the server prints to stdout you simply won't see. You will use box.execute EXPLAIN, right? As 'dead' here I meant useless/unusable/not-worth-the-efforts-of-fixing. Not unreachable.