From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BBBDF29D8B for ; Fri, 15 Mar 2019 10:42:04 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gQeyr7Rk-f50 for ; Fri, 15 Mar 2019 10:42:04 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ADAA429D4B for ; Fri, 15 Mar 2019 10:41:49 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 0/3] Make LIKE accept only arguments of type TEXT References: From: Vladislav Shpilevoy Message-ID: <6f8271e5-2144-e5a1-93df-36455a1fef39@tarantool.org> Date: Fri, 15 Mar 2019 17:41:45 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Nikita Pettik , Kirill Yukhin LGTM. On 09/03/2019 19:59, Nikita Pettik wrote: > First two patches simply remove unnecessary macro and code connected > with it. Third one - disallows arguments of LIKE be of different > from text-like types. > > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3954-disallow-blob-in-like > Issue: https://github.com/tarantool/tarantool/issues/3954 > > Nikita Pettik (3): > sql: remove SQL_LIKE_DOESNT_MATCH_BLOBS > sql: remove sql_like_count global counter > sql: make LIKE accept only TEXT arguments > > src/box/sql/func.c | 34 +++++++++----------- > src/box/sql/sqlInt.h | 2 -- > src/box/sql/vdbe.c | 14 +-------- > src/box/sql/vdbeInt.h | 6 ++++ > src/box/sql/where.c | 8 ----- > src/box/sql/whereInt.h | 4 --- > src/box/sql/wherecode.c | 73 ------------------------------------------- > test/sql-tap/tkt1537.test.lua | 4 +-- > test/sql/types.result | 45 ++++++++++++++++++++++++++ > test/sql/types.test.lua | 15 +++++++++ > 10 files changed, 84 insertions(+), 121 deletions(-) > > -- > 2.15.1 > >