From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix edge cases when generating IR for string.byte/sub/find.
Date: Tue, 10 Mar 2026 15:44:15 +0300 [thread overview]
Message-ID: <6eae0526-801f-454c-9828-854fa3493574@tarantool.org> (raw)
In-Reply-To: <aa_7atz3R_vnf-GC@root>
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
Thanks! LGTM
On 3/10/26 14:07, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed your comment and rebased the branch to the current tarantool/master.
<snipped>
[-- Attachment #2: Type: text/html, Size: 658 bytes --]
next prev parent reply other threads:[~2026-03-10 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 13:42 [Tarantool-patches] [PATCH luajit 0/2] Fixes for recording of string built-ins Sergey Kaplun via Tarantool-patches
2026-03-06 13:42 ` [Tarantool-patches] [PATCH luajit 1/2] Fix edge cases when generating IR for string.byte/sub/find Sergey Kaplun via Tarantool-patches
2026-03-10 7:29 ` Sergey Bronnikov via Tarantool-patches
2026-03-10 11:07 ` Sergey Kaplun via Tarantool-patches
2026-03-10 12:44 ` Sergey Bronnikov via Tarantool-patches [this message]
2026-03-06 13:42 ` [Tarantool-patches] [PATCH luajit 2/2] Fix edge cases when recording string.byte/sub Sergey Kaplun via Tarantool-patches
2026-03-10 9:59 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eae0526-801f-454c-9828-854fa3493574@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/2] Fix edge cases when generating IR for string.byte/sub/find.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox