[Tarantool-patches] [PATCH juajit 0/1] build: missed header when -DLUAJIT_DISABLE_JIT=ON

[Tarantool-patches] [PATCH juajit 0/1] build: missed header when -DLUAJIT_DISABLE_JIT=ON

[Denis Smirnov via Tarantool-patches]

Hi all,

It seems that it is impossible to build luajit with -DLUAJIT_DISABLE_JIT=ON flag because of the missed header. Here is a small fix attached.

Denis Smirnov (1):
  build: fix build with disabled lua jit

 src/lj_memprof.c | 1 +
 1 file changed, 1 insertion(+)

[Tarantool-patches] [PATCH luajit 1/1] build: missed header when -DLUAJIT_DISABLE_JIT=ON

[Denis Smirnov via Tarantool-patches]

Previously it was impossible to build Lua JIT with disabled JIT
option (-DLUAJIT_DISABLE_JIT=ON flag) because of the missed include.
Fixed.
---
 src/lj_memprof.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lj_memprof.c b/src/lj_memprof.c
index d4a639fd..4a35613c 100644
--- a/src/lj_memprof.c
+++ b/src/lj_memprof.c
@@ -11,6 +11,7 @@
 #include <errno.h>
 
 #include "lj_arch.h"
+#include "lj_jit.h"
 #include "lj_memprof.h"
 
 #if LJ_HASMEMPROF
-- 
2.32.0 (Apple Git-132)

Re: [Tarantool-patches] [PATCH luajit 1/1] build: missed header when -DLUAJIT_DISABLE_JIT=ON

[Sergey Kaplun via Tarantool-patches]

Hi, Denis!

Thanks for the patch!

Please, consider my comments below.

On 29.04.22, Denis Smirnov via Tarantool-patches wrote:
> Previously it was impossible to build Lua JIT with disabled JIT
> option (-DLUAJIT_DISABLE_JIT=ON flag) because of the missed include.
> Fixed.

Nit: I proposed the following rewording:

|
| This patch adds the necessary include.

> ---

Your branch is outdated regarding "master" (tarantool) branch.
So the build is still failing with disabled JIT.

Also, it is necessary to introduce new CI jobs with disabled JIT (and
mb memprof) -- it allows to avoid such troubles in future. It is a good
thing, and help with this is valuable and appreciated.

NB: JIT-related (or memprof-related) tests should be disabled for such
pipeline. So we need to introduce disabling mechanism by these factors.

>  src/lj_memprof.c | 1 +

Please, check that Makefile.dep.original is updated corresponding new
added header.

>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/lj_memprof.c b/src/lj_memprof.c
> index d4a639fd..4a35613c 100644
> --- a/src/lj_memprof.c
> +++ b/src/lj_memprof.c
> @@ -11,6 +11,7 @@
>  #include <errno.h>
>  
>  #include "lj_arch.h"
> +#include "lj_jit.h"
>  #include "lj_memprof.h"
>  
>  #if LJ_HASMEMPROF
> -- 
> 2.32.0 (Apple Git-132)
> 

-- 
Best regards,
Sergey Kaplun