From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8E1394696C4
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 14 Feb 2020 02:26:10 +0300 (MSK)
References: <20200206123114.8010-1-gorcunov@gmail.com>
 <20200206123114.8010-2-gorcunov@gmail.com>
 <ae7eaa9c-7074-15a6-c91d-dafb5d1e3d0a@tarantool.org>
 <20200213081950.GM21061@uranus>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <6e0f734a-0415-8abc-8301-759a3135da12@tarantool.org>
Date: Fri, 14 Feb 2020 00:26:09 +0100
MIME-Version: 1.0
In-Reply-To: <20200213081950.GM21061@uranus>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v6 1/2] fiber: set diagnostics at
	madvise/mprotect failure
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

>>> diff --git a/test/unit/fiber_stack.cc b/test/unit/fiber_stack.cc
>>> new file mode 100644
>>> index 000000000..de7fe90e3
>>> --- /dev/null
>>> +++ b/test/unit/fiber_stack.cc
>>
>> 4. Do you need C++ here?
> 
> The C++ was choosen because we already have fiber_XXX.cc tests
> so I simply tried to follow.
> 
>> 5. I would call it fiber_errinj.c. In future we may want to
>> add more tests here, which use error injections. Up to you.
> 
> From one point of view having one big test which would cover
> various aspects of tarantool might help discovering unexpectedly
> connected bugs.

In case of unit tests it is rather about reducing code duplication.
Because any fiber unit test on C includes the same headers, does
the same preparations in main(), may need some common utilities.