From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 83239469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  6 May 2020 20:52:58 +0300 (MSK)
References: <cover.1587948306.git.korablev@tarantool.org>
 <1094177fe18b811b8b6f49f03e2ced30e798b95b.1587948306.git.korablev@tarantool.org>
 <e7e8cef8-19f8-618e-4a33-6d93d8eb40b5@tarantool.org>
 <20200506131204.GA7218@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <6d861b87-9a24-77c8-a306-0299f4b88985@tarantool.org>
Date: Wed, 6 May 2020 20:52:57 +0300
MIME-Version: 1.0
In-Reply-To: <20200506131204.GA7218@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH v3 1/3] vinyl: init all vars before
 cleanup in vy_lsm_split_range()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

I agree. This particular commit lgtm.

On 5/6/20 4:12 PM, Nikita Pettik wrote:
> On 06 May 12:04, Aleksandr Lyapunov wrote:
>> Nice catch! Jumps over initialization must be prohibited. As C++ prohibits.
>>
> If everyone is okay with this patch, let's push it out of order.
>