From: Leonid Vasiliev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Artem Starshov <artemreyt@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCHv3 0/2] lua: fix tarantool -e always enters interactive mode
Date: Fri, 5 Mar 2021 15:44:18 +0300 [thread overview]
Message-ID: <6d33f734-6cca-ba33-0bca-6fce61d373cf@tarantool.org> (raw)
In-Reply-To: <cover.1614848123.git.artemreyt@tarantool.org>
Hi!
Please, add changelogs according to `doc/changelogs.md`.
On 3/4/21 12:15 PM, Artem Starshov wrote:
> Issue: https://github.com/tarantool/tarantool/issues/5040
> Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug
> CI: https://github.com/tarantool/tarantool/runs/2029377964
>
> Changes in v3:
> * core:
> - add case-insensetive value for boolean error injection;
> - add more tests for setting error injections;
> - few refactored things (80 line width, alignment and etc.);
> - add release_disable for test;
> - add reference to test-run issue in commit message;
> - now, it is able to set errinjs via env ONLY in Debug mode.
> * lua:
> - some refactoring (name of variables, 80 line-width..);
> - add release_disable for test;
> - add reference to test-run issue in commit message;
> - add "errinj" to the name of the test;
> - add comments to source code.
>
> Artem Starshov (2):
> core: add setting error injections via env
> lua: fix tarantool -e always enters interactive mode
>
> src/lib/core/errinj.c | 30 +++++
> src/lib/core/errinj.h | 6 +
> src/lua/init.c | 27 +++-
> src/main.cc | 3 +
> ...5040-inter-mode-isatty-via-errinj.test.lua | 126 ++++++++++++++++++
> test/app-tap/suite.ini | 1 +
> .../errinj_set_with_enviroment_vars.test.lua | 29 ++++
> ...errinj_set_with_enviroment_vars_script.lua | 34 +++++
> test/box-tap/suite.ini | 1 +
> test/box/errinj.result | 1 +
> 10 files changed, 254 insertions(+), 4 deletions(-)
> create mode 100755 test/app-tap/gh-5040-inter-mode-isatty-via-errinj.test.lua
> create mode 100755 test/box-tap/errinj_set_with_enviroment_vars.test.lua
> create mode 100644 test/box-tap/errinj_set_with_enviroment_vars_script.lua
>
next prev parent reply other threads:[~2021-03-05 12:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 9:15 Artem Starshov via Tarantool-patches
2021-03-04 9:15 ` [Tarantool-patches] [PATCHv3 1/2] core: add setting error injections via env Artem Starshov via Tarantool-patches
2021-03-05 12:11 ` Leonid Vasiliev via Tarantool-patches
2021-03-10 12:48 ` Artem via Tarantool-patches
2021-03-04 9:15 ` [Tarantool-patches] [PATCHv3 2/2] lua: fix tarantool -e always enters interactive mode Artem Starshov via Tarantool-patches
2021-03-05 12:31 ` Leonid Vasiliev via Tarantool-patches
2021-03-05 12:44 ` Leonid Vasiliev via Tarantool-patches [this message]
2021-03-10 13:00 ` [Tarantool-patches] [PATCHv3 0/2] " Artem via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d33f734-6cca-ba33-0bca-6fce61d373cf@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=artemreyt@tarantool.org \
--cc=lvasiliev@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCHv3 0/2] lua: fix tarantool -e always enters interactive mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox