From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BA66B6ECE3; Mon, 4 Jul 2022 13:06:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BA66B6ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656929213; bh=YVFL/K8jyCpEi0Gut6Aby+NJNLVL4S7PyvX7l/I6hgo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=yHwJPLgFAsqEpqWgQdGu1MYfD1BLJr0bn6Bx0tAEYBtharaPDT5CnUlmRuZCCGnV9 jZ5BzNx89pBzK37JYd+SFhX6v2bOmrEuY0C1c+/RLxGK43K7k+DRN1s8YqY3/6fD2V F50L+jZgrNlKfGujI93bEna8j5+/hxDzrs5riHtE= Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A62FE6ECE3 for ; Mon, 4 Jul 2022 13:06:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A62FE6ECE3 Received: by mail-lf1-f53.google.com with SMTP id z21so14867811lfb.12 for ; Mon, 04 Jul 2022 03:06:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PP23B9OY3CE3WbbXCO1jCkhuRDYeR3G7TjvsT2991A0=; b=a6gRt9kVzVcWJ/ifa/gHU1F0nqbYBTJ+ry9x0rAvJQHNRNXq4Hoyi8nNxlyhAK03o0 tPsCOQZRaqg0ayULT/hl/ajufXA8TqiguNY7h9SvCP5Td7AvnXQHTqIS/768pt4pQaNx HsJo+yH8sruB6kWTLYH2L6+PH18aETojDs0LxbgTSgk388jCnByhNvKRzFeHBkVOZJRQ lx4Uzjb800MHKsd5Ds6AwEKaThtLTyxLc+nga9E4/Y+kJWSuInCLK9w0tESDmEJlRNCW D0QBlqf4dnQKqqvYsjiMF9IUgteyliJ9zgxlnzcD6tr7oqR007REdFJdZNgz/OwiyGvj FxCQ== X-Gm-Message-State: AJIora+N5ugPq5CjnCcIbZ3Zf05yg/+7Wo9b/Q//E42GH7pWhhbCkcMs ZrGuED9MmpvMOzFxVjwR0finoFvMWYs= X-Google-Smtp-Source: AGRyM1uhUCSeFjdyJvFsc+chFsDqrIq/WQaKHEE8t1cNCDIRdVxehVK54oCKW9B+9Brcqc0aKZPHqA== X-Received: by 2002:a05:6512:3195:b0:481:620b:9bb2 with SMTP id i21-20020a056512319500b00481620b9bb2mr10297856lfe.336.1656929211017; Mon, 04 Jul 2022 03:06:51 -0700 (PDT) Received: from [192.168.43.168] ([178.176.74.241]) by smtp.gmail.com with ESMTPSA id b8-20020a056512218800b0047f7c897b61sm5054558lft.129.2022.07.04.03.06.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 03:06:50 -0700 (PDT) Message-ID: <6d0cdb9e-561d-b3a5-aeda-82406e93fb80@gmail.com> Date: Mon, 4 Jul 2022 13:06:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Sergey Kaplun References: <62acf609d9e1ea43d95cb27213e1b8f1331b57a7.1656685987.git.sergeyb@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] build: configure parallel jobs X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! Fixed and force-pushed. Sergey On 04.07.2022 12:52, Sergey Kaplun wrote: > Hi, Sergey! > > Thanks for the patch! > > LGTM, except a few nits regarding the commit message. > > On 01.07.22, Sergey Bronnikov wrote: >> lua-Harness and tarantool testsuites uses a prove(1) for running tests. > Typo: s/testsuites/test suites/ > >> prove(1) allows to run tests in parallel with option "--jobs" [1]. > Typo: s/option/the option/ > >> In CMake it is not possible to get a number of parallel jobs in CMake >> passed by user with option "-j", but it allows to pass a number of >> parallel jobs with environment variable CMAKE_BUILD_PARALLEL_LEVEL [2] >> on configuration phase. We use a value set by that environment variable >> and set it to a number of CPU threads when it was not specified by user. > Typo: s/user/the user/ > >> Number of CPU threads detected using builtin CMake function [3]. >> >> NOTE: CMAKE_BUILD_PARALLEL_LEVEL has been added in a version 3.12. >> >> 1. https://perldoc.perl.org/prove >> 2. https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html >> 3. https://cmake.org/cmake/help/latest/module/ProcessorCount.html >> --- >> >> Branch: https://github.com/tarantool/luajit/tree/ligurio/prove-in-parallel >> CI: https://github.com/tarantool/luajit/commit/62acf609d9e1ea43d95cb27213e1b8f1331b57a7 >> >> test/CMakeLists.txt | 13 +++++++++++++ >> test/lua-Harness-tests/CMakeLists.txt | 1 + >> test/tarantool-tests/CMakeLists.txt | 1 + >> 3 files changed, 15 insertions(+) >> > > >> -- >> 2.25.1 >>