From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CE63915D790A; Mon, 17 Nov 2025 17:23:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CE63915D790A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763389409; bh=4LWyxmbqG4q0X/82+waFlyRK5DX/4ViBY1883WJSGdE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=C7aKwWcbThsXX0aoIXVIlIoiKeqSwSqJfeAPYyukXAAYasx70kpO2+lKlh9lLpmUJ 3xvqJhq6G+lIviBYJ8EHUarxu8A6VFkA1wWq3qAXOEoxC/CMEE/Z3i0ZhaHm+/0bmW 5MnwINhP91B9Or1bniAWe8SbLB7mPe74jTX9tFyU= Received: from send243.i.mail.ru (send243.i.mail.ru [95.163.59.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1790915D790A for ; Mon, 17 Nov 2025 17:23:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1790915D790A Received: by exim-smtp-88cf54d45-lpvct with esmtpa (envelope-from ) id 1vL08e-00000000HT6-0wTi; Mon, 17 Nov 2025 17:23:28 +0300 Content-Type: multipart/alternative; boundary="------------xdoU9ueTSn9r9PFmCIhrY97D" Message-ID: <6d0b92fa-a3b7-4a12-b4e8-41faf06e7740@tarantool.org> Date: Mon, 17 Nov 2025 17:23:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <800b8e4d42b3d8f51ad2a5686799004b09e0e719.1761301736.git.skaplun@tarantool.org> In-Reply-To: <800b8e4d42b3d8f51ad2a5686799004b09e0e719.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD99F284BE5F96F126D312E55A5CBDF34CE7C08F0781D9C0775182A05F5380850404C228DA9ACA6FE27EA2B2F4BB8445F783DE06ABAFEAF67056966F71D988DAADF83E3C9BD2A428B32821D67526267DAEB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79E25BE5045FD62C0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2791704ECD371DE992E070BE324C7D3C41496EC8737C59C83F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22498424CA1AAF98A6958941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249E473A0F43A664A8D76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B8D91A52B72CA83B53AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735BA6625F88748EAEFC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5C86D026D97A60CA15002B1117B3ED696196D6FEC19A1D179B2920F75BA9A967F823CB91A9FED034534781492E4B8EEADAE4FDBF11360AC9BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF1AC476DBA64297127D964996C3809FF6F77509A1D57E2430ED6B854422881BAF257E6C4F5EEB673EDD6EA89E5C47541BCEA8967D6BCF494FA59D37889BAD39D3D38A8A443C9D2786111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1IHC6FWHbnvc= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59D52EBC876C1DB81F3DE06ABAFEAF67056966F71D988DAADFB7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 35/41] perf: adjust spectral-norm in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------xdoU9ueTSn9r9PFmCIhrY97D Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey,  thanks for the patch! See my comments below. Sergey On 10/24/25 14:00, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > --- > perf/LuaJIT-benches/spectral-norm.lua | 40 +++++++++++++++++++-------- > 1 file changed, 29 insertions(+), 11 deletions(-) > > diff --git a/perf/LuaJIT-benches/spectral-norm.lua b/perf/LuaJIT-benches/spectral-norm.lua > index ecc80112..6e63cd47 100644 > --- a/perf/LuaJIT-benches/spectral-norm.lua > +++ b/perf/LuaJIT-benches/spectral-norm.lua > @@ -1,3 +1,4 @@ > +local bench = require("bench").new(arg) > > local function A(i, j) > local ij = i+j-1 > @@ -25,16 +26,33 @@ local function AtAv(x, y, t, N) > Atv(t, y, N) > end > > -local N = tonumber(arg and arg[1]) or 100 > -local u, v, t = {}, {}, {} > -for i=1,N do u[i] = 1 end > +local N = tonumber(arg and arg[1]) or 3000 Why it was changed to 3000? > > -for i=1,10 do AtAv(u, v, t, N) AtAv(v, u, t, N) end > +bench:add({ > + name = "spectral_norm", > + checker = function(res) > + -- XXX: Empirical value. > + if N > 66 then > + assert(math.abs(res - 1.27422) < 0.00001) > + end > + return true > + end, > + payload = function() > + local u, v, t = {}, {}, {} > + for i=1,N do u[i] = 1 end add more whitespaces, here and below > > -local vBv, vv = 0, 0 > -for i=1,N do > - local ui, vi = u[i], v[i] > - vBv = vBv + ui*vi > - vv = vv + vi*vi > -end > -io.write(string.format("%0.9f\n", math.sqrt(vBv / vv))) > + for i=1,10 do AtAv(u, v, t, N) AtAv(v, u, t, N) end > + > + local vBv, vv = 0, 0 > + for i=1,N do > + local ui, vi = u[i], v[i] > + vBv = vBv + ui*vi > + vv = vv + vi*vi > + end > + return math.sqrt(vBv / vv) > + end, > + -- Operations inside `for i=1,10` loop. > + items = 40 * N * N, > +}) > + > +bench:run_and_report() --------------xdoU9ueTSn9r9PFmCIhrY97D Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

 thanks for the patch! See my comments below.

Sergey

On 10/24/25 14:00, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.
---
 perf/LuaJIT-benches/spectral-norm.lua | 40 +++++++++++++++++++--------
 1 file changed, 29 insertions(+), 11 deletions(-)

diff --git a/perf/LuaJIT-benches/spectral-norm.lua b/perf/LuaJIT-benches/spectral-norm.lua
index ecc80112..6e63cd47 100644
--- a/perf/LuaJIT-benches/spectral-norm.lua
+++ b/perf/LuaJIT-benches/spectral-norm.lua
@@ -1,3 +1,4 @@
+local bench = require("bench").new(arg)
 
 local function A(i, j)
   local ij = i+j-1
@@ -25,16 +26,33 @@ local function AtAv(x, y, t, N)
   Atv(t, y, N)
 end
 
-local N = tonumber(arg and arg[1]) or 100
-local u, v, t = {}, {}, {}
-for i=1,N do u[i] = 1 end
+local N = tonumber(arg and arg[1]) or 3000
Why it was changed to 3000? 
 
-for i=1,10 do AtAv(u, v, t, N) AtAv(v, u, t, N) end
+bench:add({
+  name = "spectral_norm",
+  checker = function(res)
+    -- XXX: Empirical value.
+    if N > 66 then
+      assert(math.abs(res - 1.27422) < 0.00001)
+    end
+    return true
+  end,
+  payload = function()
+    local u, v, t = {}, {}, {}
+    for i=1,N do u[i] = 1 end
add more whitespaces, here and below 
 
-local vBv, vv = 0, 0
-for i=1,N do
-  local ui, vi = u[i], v[i]
-  vBv = vBv + ui*vi
-  vv = vv + vi*vi
-end
-io.write(string.format("%0.9f\n", math.sqrt(vBv / vv)))
+    for i=1,10 do AtAv(u, v, t, N) AtAv(v, u, t, N) end
+
+    local vBv, vv = 0, 0
+    for i=1,N do
+      local ui, vi = u[i], v[i]
+      vBv = vBv + ui*vi
+      vv = vv + vi*vi
+    end
+    return math.sqrt(vBv / vv)
+  end,
+  -- Operations inside `for i=1,10` loop.
+  items = 40 * N * N,
+})
+
+bench:run_and_report()
--------------xdoU9ueTSn9r9PFmCIhrY97D--