From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4F0719C95C6; Thu, 1 Feb 2024 17:32:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4F0719C95C6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706797952; bh=VuYpgntUEPAT2XhwuQMjxmPownILnClXRes2DDBRDTo=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LwZAk+rfkK3EPhnIG1JPz618jjMMxZ4jhWl0oihWztpIYFosxGceCERuU0ZBFwjFM AI8RQ5q7c8wMWqaAg6O560jkPUE8iYOPKilGjUFGfkDxQlmraRQqYEzSErjNASexGp GQ10E77TMULj0Wrs1znhejxxPq+I4VgLDhKspWrI= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [95.163.41.92]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 544F37346C0 for ; Thu, 1 Feb 2024 17:32:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 544F37346C0 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1rVY7C-00000000zqi-2EEN; Thu, 01 Feb 2024 17:32:30 +0300 Message-ID: <6cda5e07-00a9-440d-a6e1-0044dda8f889@tarantool.org> Date: Thu, 1 Feb 2024 17:32:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9010253A383FA2A75BEB76216D7784AEC912E83F708D1D0F2182A05F5380850405F0F2770E472C8FD3DE06ABAFEAF6705333D0CFC24DCF35A4F260441819476B88B3203750C901C87 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78AC0750F3304E924EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637803A71E7516670C28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C55A33326A1D6EABF7E837053EEC5A9F5297B50AADC93686CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C98E93883770458356136E347CC761E074AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3C9DEF68986073825BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE478A468B35FE7671DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE765B758295022C166731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A543ED1649FA1263025002B1117B3ED69677195D2D29F6B47469995D676B7B4CBE823CB91A9FED034534781492E4B8EEADBEC81E4AEBD6D2BFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF258A5C9076078ADB1268DB30139CB42DC872D7AB94E7F98E3859E3FAB3A1B73E1230ACE34F2D113DBAF4CF3B87E910B1B56AE9098010C769BE7AA3EE8E235A65677DC8A4A711DBD85F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqJaWtPsRtymNKBVWzBZdFQ== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F25884580CE880833450CC671F93A76BF6F7B0A65EBA1AA845D940A13BFF37FBA760C598645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 08/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for the patch! LGTM with a minor comment below On 1/29/24 13:45, Sergey Kaplun wrote: > This patch changes the `dofile()` (which uses an unreliable relative > file path and mutates `_G` with global functions to be defined) to the > corresponding `require()`. Also, it names the only one test as "misc" extra whitespace before "Also" > and includes the test in . > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/lib/ffi/ffi_const.lua | 4 ++-- > test/LuaJIT-tests/lib/ffi/index | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_const.lua b/test/LuaJIT-tests/lib/ffi/ffi_const.lua > index d42133ad..3213156d 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_const.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_const.lua > @@ -1,6 +1,6 @@ > local ffi = require("ffi") > > -dofile("../common/ffi_util.inc") > +local fails = require("common.fails") > > ffi.cdef[[ > typedef struct s_t { > @@ -41,7 +41,7 @@ typedef struct foo_t { > } foo_t; > ]] > > -do > +do --- misc > local foo_t = ffi.typeof("foo_t") > local x = foo_t() > > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index > index 9a22104a..0a72daed 100644 > --- a/test/LuaJIT-tests/lib/ffi/index > +++ b/test/LuaJIT-tests/lib/ffi/index > @@ -6,6 +6,7 @@ ffi_arith_ptr.lua > ffi_bitfield.lua > ffi_call.lua > ffi_callback.lua > +ffi_const.lua > istype.lua > jit_array.lua > jit_complex.lua