From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 740BD469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 22 Sep 2020 20:51:17 +0300 (MSK)
References: <1599560532-27089-1-git-send-email-alyapunov@tarantool.org>
 <1599560532-27089-8-git-send-email-alyapunov@tarantool.org>
 <20200915143357.GB23208@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <6c7eb860-781c-78b4-3fca-49199de2aa64@tarantool.org>
Date: Tue, 22 Sep 2020 20:51:16 +0300
MIME-Version: 1.0
In-Reply-To: <20200915143357.GB23208@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH v4 07/12] txm: introduce memtx_story
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thank for the review.
Most is fixed, see my replies below.

On 15.09.2020 17:33, Nikita Pettik wrote:

>> +int
>> +memtx_tx_track_read(struct txn *txn, struct space *space, struct tuple *tuple)
>> +{
>> +	if (tuple == NULL)
>> +		return 0;
>> +	if (txn == NULL)
>> +		return 0;
>> +	if (space == NULL)
>> +		return 0;
> Space seems to be always != NULL. If so, let's replace it with an assertion.
I found out that in iterators the space can be NULL. I'm not sure
why, but I happens without my patch set. I just accepted it.