From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E862A25F69 for ; Thu, 14 Jun 2018 15:27:24 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EjxYG8VJy1zj for ; Thu, 14 Jun 2018 15:27:24 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9AC7125F22 for ; Thu, 14 Jun 2018 15:27:24 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v3 06/10] sql: move sqlite3DeleteTrigger to sql.h References: From: Vladislav Shpilevoy Message-ID: <6be24107-ea9e-a646-69d3-792db53a1b92@tarantool.org> Date: Thu, 14 Jun 2018 22:27:20 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Thanks for the fixes! I have pushed other review fixes as a separate commit. Please, look and squash. On 14/06/2018 20:32, Kirill Shcherbatov wrote: > As we are going to port triggers to server, we need > an instrument to release allocated memory in alter.cc. > > Part of #3273. > --- > src/box/sql.h | 9 +++++++++ > src/box/sql/callback.c | 7 +++---- > src/box/sql/sqliteInt.h | 3 +-- > src/box/sql/status.c | 6 +++--- > src/box/sql/tokenize.c | 2 +- > src/box/sql/trigger.c | 30 +++++++++++++----------------- > 6 files changed, 30 insertions(+), 27 deletions(-) >