From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CF0087030F; Fri, 6 Aug 2021 01:14:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CF0087030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628201688; bh=1kO8BhkFNwwghM6+rWFKePyqQ+iaZ4gpBPTtzZqtAZc=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UHvm/7GqT2jDR5jL4ef80JtV3y9mUGMuWbi6TWry60jbyczYbFz+nC8kRLcUlq7B8 OyOlB//4Ex7AgLObbvVJeZc1bNp+hFOCCP5P06LM7ydxoJUUOKxM7mlOoCB/sZQY0p ZK2VOe6ypq8SIIfdfEoJrB+SC94q0wuj01d37Kks= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 75A296FC81 for ; Fri, 6 Aug 2021 01:14:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 75A296FC81 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1mBldW-00042f-BN; Fri, 06 Aug 2021 01:14:46 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <3f946be6c0aff87c70ac318ae7d5781350fe20f5.1628081224.git.imeevma@gmail.com> Message-ID: <6bcdc3da-9391-1b75-8a59-e1f7d5fffedf@tarantool.org> Date: Fri, 6 Aug 2021 00:14:45 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <3f946be6c0aff87c70ac318ae7d5781350fe20f5.1628081224.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9BCE6B93DE0C6C3914462CDB1732D383C182A05F538085040CAFF78859B763F62D9FB213241D9DCC8B2B33114A2835B16D39A023C843BE4C8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D52C0B46024FCC4BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748424D8FCCA3295D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D886D04347CA3B1DBE49509550466FD6B8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACDEA93887B71B66F2BD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3A7DFDF579AB090EF2D242C3BD2E3F4C6C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D94463893BF8742D0AAB9ADDE9345D3DC X-C1DE0DAB: 0D63561A33F958A54FB077E8AC7DAF8387F1FFDC9192140D811418E9D31A6592D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B9F55CA4D2956E305C4B23D3E5F035AEAD1EB3EAEF13806CA038132DAA6384C7B53EA5C6B6A2E60B1D7E09C32AA3244CDE74BE8D33357C3FC31586E9B03582D469B6CAE0477E908D729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFhlvmGwdUwTJxeuy3sf1+A== X-Mailru-Sender: 1F3202E75A95DDEFC23907419AE0C7D7CC6A28EA2FE7DE379B84BD826199C12DFD37AB140C05BBCE07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 1/6] sql: introduce sql_func_flags() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! > diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h > index 115c52f96..97b7a2401 100644 > --- a/src/box/sql/sqlInt.h > +++ b/src/box/sql/sqlInt.h > @@ -1186,6 +1186,8 @@ struct type_def { > * SQL_FUNC_LENGTH == OPFLAG_LENGTHARG > * SQL_FUNC_TYPEOF == OPFLAG_TYPEOFARG > */ > +/** Function is one of aggregate functions. */ > +#define SQL_FUNC_AGG 0x0001 The value is misaligned with the values below. They are using whitespaces, so this new line probably also should use them. > #define SQL_FUNC_LIKE 0x0004 /* Candidate for the LIKE optimization */ > #define SQL_FUNC_NEEDCOLL 0x0020 /* sqlGetFuncCollSeq() might be called.