From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C39046EC5D; Mon, 5 Apr 2021 12:05:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C39046EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617613557; bh=3gfnejUadNZBm2oLZ0qeAViyfVAT+9+Ibnwg3N2lzEE=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=AxNuFtomaOn0A4O/a5Vc1kSzp87ldYxbDwdOD6gWsZAVqt8f9kIPOzfjENe6vvDkM 5RuyLzzX4Rl+DdrHk3zcw+ErBtS4n1cF76zMZRTdueuSPXAzSwYORluH9osrChCI0Y ez4V/iJ3HKfoJlNZbXR34pH7rSvbcDO0FxrnN+pE= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8ED906EC5D for ; Mon, 5 Apr 2021 12:05:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8ED906EC5D Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1lTLBD-000711-Ni; Mon, 05 Apr 2021 12:05:56 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com References: Message-ID: <6bc99d3f-cd16-a707-bd72-be65939f15ce@tarantool.org> Date: Mon, 5 Apr 2021 12:05:55 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD433B5E0F054050395182A05F538085040EE1556D67A68A441E28C84E4B619B5C829FEE1466836202FC9E0923C5CED22A7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373768BF035B57E5168638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C16EE06F5A270FE6ABA260558F03EDCA48BB8F92E2DA69F17A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF0E3C941C2BAD3D9ABA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6D35994BF90B9183D76E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A3920E30A4C9C8E338DAA65EE29973F47D2F43847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D50C569D9A7165492355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A50FAEFE1A7D3E96D0A4F6CA68851F0C4071FE4CE054EE0DE0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A533D6DF7731C6641B1278B2F963276DBD326D963DD016A402956169139D54C2A8905EC33B2220921D7E09C32AA3244C592AA7893AE61655BD7A2A33FD31B00139C99C45E8D137E9FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojM00ve/f+0on/ExSBoFkfVw== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F82CD67E6503C537F6271EB3A684C312AB64C07447216EFC9D424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/2] Swim misusage crashes X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 04.04.2021 18:06, Vladislav Shpilevoy пишет: > The patchset fixes 2 crashes happened when SWIM API was misused. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/swim-misusage-crashes-5951-5952 > Issue: https://github.com/tarantool/tarantool/issues/5951 > Issue: https://github.com/tarantool/tarantool/issues/5952 Hi! Thanks for the patches! LGTM. > Vladislav Shpilevoy (2): > swim: fix crash on bad member_by_uuid() call > swim: check types in __serialize methods > > .../unreleased/swim-member_by_uuid-crash.md | 4 + > changelogs/unreleased/swim-serialize-crash.md | 4 + > src/lib/swim/swim.c | 2 + > src/lua/swim.lua | 41 +++++-- > test/swim/gh-5952-swim-serialize.result | 101 ++++++++++++++++++ > test/swim/gh-5952-swim-serialize.test.lua | 33 ++++++ > test/swim/swim.result | 9 ++ > test/swim/swim.test.lua | 3 + > test/unit/swim.c | 23 +++- > test/unit/swim.result | 9 +- > 10 files changed, 217 insertions(+), 12 deletions(-) > create mode 100644 changelogs/unreleased/swim-member_by_uuid-crash.md > create mode 100644 changelogs/unreleased/swim-serialize-crash.md > create mode 100644 test/swim/gh-5952-swim-serialize.result > create mode 100644 test/swim/gh-5952-swim-serialize.test.lua > -- Serge Petrenko