From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 442EF469711
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 22 May 2020 14:49:00 +0300 (MSK)
References: <20200518093748.16825-1-skaplun@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <6b1a3a5d-98b4-66fc-ec80-322c8f3531a0@tarantool.org>
Date: Fri, 22 May 2020 14:48:58 +0300
MIME-Version: 1.0
In-Reply-To: <20200518093748.16825-1-skaplun@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH] lua: lua_field_inspect_table
	without pushcfunction
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>, tarantool-patches@dev.tarantool.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Thanks for the patch! I agree with Vlad's comments.
I have only one insignificant comment, see below.
The rest LGTM, but I'm not a Lua expert an could miss something.

On 5/18/20 12:37 PM, Sergey Kaplun wrote:
> + * Return values:
> + * -1 - error, set diag
> + *  0 - has serialize, success replace and have to finish
> + *  1 - hasn't serialize, need to process
I would say "doesn't have" or "hasn't got".