From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 40E8F46970E
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 30 Dec 2019 01:35:38 +0300 (MSK)
References: <77b2090c-4bfd-c42c-e744-3395eef2e8a3@tarantool.org>
 <FE9F3144-D4E5-4742-8AC8-9363A49C3797@tarantool.org>
 <f982e884-1835-22ff-4237-3ac001965bda@tarantool.org>
 <721EA98D-2EC6-4C4C-97B0-6BCEBE889EDA@tarantool.org>
 <20007117-f560-e06d-16a5-67e811c8f9f8@tarantool.org>
 <88F2A14C-2D86-4C17-90F1-4B0388CF71C9@tarantool.org>
 <20191228001833.GA45089@tarantool.org>
 <b8edb143-c126-fe9b-893e-97ce6e8d8df3@tarantool.org>
 <20191229000717.GB44517@tarantool.org>
 <741cb846-6f91-1427-9e18-3d4be6855f5e@tarantool.org>
 <20191229222839.GB44588@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <6ad7db18-665c-e599-a5f5-2da1a41af084@tarantool.org>
Date: Mon, 30 Dec 2019 01:35:35 +0300
MIME-Version: 1.0
In-Reply-To: <20191229222839.GB44588@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 2/3] box: make constraint
 operations transactional
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

> Anyway, patch LGTM. This is second one approve so it can be pushed,
> but Sergos wrote that he is concerned about memory management
> during constraint id creation/drop. Sergos, did you find any
> issues, or we can push this patch?

I see sometimes, that random box tests hang. In logs I see
nothing, or mp_tuple_assert fail even before a test is started.
I tried to run with ASAN - found nothing. Did one another
self-review - nothing. Probably these were problems with luajit,
don't know. Can't reproduce anywhere.