Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org,
	sergeyb@tarantool.org
Subject: [Tarantool-patches] [PATCH luajit v2 3/5] Revert "arm64: fix cur_L restoration on error throw"
Date: Fri, 29 Sep 2023 09:20:12 +0300	[thread overview]
Message-ID: <6a861ad27810eab2c5fd5bc659027b5a57f6577f.1695968227.git.m.kokryashkin@tarantool.org> (raw)
In-Reply-To: <cover.1695968227.git.m.kokryashkin@tarantool.org>

This reverts commit 7570ff61138fb50a17ed78ee28dde0acbbf6131e.

As was mentioned in tarantool/tarantool#6189, throwing an error
not on the currently executed coroutine is a violation of the
Lua/C API. This patch is a part of the patchset that supports
this violation and is reverted because of it.

Part of tarantool/tarantool#6323
---
 src/vm_arm64.dasc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/vm_arm64.dasc b/src/vm_arm64.dasc
index de33bde4..0a12b5b7 100644
--- a/src/vm_arm64.dasc
+++ b/src/vm_arm64.dasc
@@ -395,7 +395,6 @@ static void build_subroutines(BuildCtx *ctx)
   |   mv_vmstate TMP0w, CFUNC
   |  ldr GL, L->glref
   |   st_vmstate TMP0w
-  |  str L, GL->cur_L
   |  b ->vm_leave_unw
   |
   |->vm_unwind_ff:			// Unwind C stack, return from ff pcall.
@@ -411,7 +410,6 @@ static void build_subroutines(BuildCtx *ctx)
   |   ldr GL, L->glref			// Setup pointer to global state.
   |    mov_false TMP0
   |  sub RA, BASE, #8			// Results start at BASE-8.
-  |   str L, GL->cur_L
   |  ldr PC, [BASE, FRAME_PC]		// Fetch PC of previous frame.
   |    str TMP0, [BASE, #-8]		// Prepend false to error message.
   |   st_vmstate ST_INTERP
-- 
2.42.0


  parent reply	other threads:[~2023-09-29  6:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29  6:20 [Tarantool-patches] [PATCH luajit v2 0/5] Fix error-throwing on an incorrect coroutine Maxim Kokryashkin via Tarantool-patches
2023-09-29  6:20 ` [Tarantool-patches] [PATCH luajit v2 1/5] Revert "Fix cur_L tracking on exceptional path" Maxim Kokryashkin via Tarantool-patches
2023-10-03 18:54   ` Sergey Bronnikov via Tarantool-patches
2023-10-04 11:27     ` Maxim Kokryashkin via Tarantool-patches
2023-10-06  8:28       ` Sergey Bronnikov via Tarantool-patches
2023-10-10  8:19   ` Sergey Kaplun via Tarantool-patches
2023-09-29  6:20 ` [Tarantool-patches] [PATCH luajit v2 2/5] Revert "Update cur_L " Maxim Kokryashkin via Tarantool-patches
2023-10-03 18:55   ` Sergey Bronnikov via Tarantool-patches
2023-10-04 11:27     ` Maxim Kokryashkin via Tarantool-patches
2023-10-06  8:28       ` Sergey Bronnikov via Tarantool-patches
2023-10-10  8:20   ` Sergey Kaplun via Tarantool-patches
2023-09-29  6:20 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-10-06  8:29   ` [Tarantool-patches] [PATCH luajit v2 3/5] Revert "arm64: fix cur_L restoration on error throw" Sergey Bronnikov via Tarantool-patches
2023-10-10  8:21   ` Sergey Kaplun via Tarantool-patches
2023-09-29  6:20 ` [Tarantool-patches] [PATCH luajit v2 4/5] Revert "Update cur_L on exceptional path (arm)" Maxim Kokryashkin via Tarantool-patches
2023-10-06  8:29   ` Sergey Bronnikov via Tarantool-patches
2023-10-10  8:21   ` Sergey Kaplun via Tarantool-patches
2023-09-29  6:20 ` [Tarantool-patches] [PATCH luajit v2 5/5] Restore cur_L for specific Lua/C API use case Maxim Kokryashkin via Tarantool-patches
2023-10-03 19:16   ` Sergey Bronnikov via Tarantool-patches
2023-10-04 11:26     ` Maxim Kokryashkin via Tarantool-patches
2023-10-06  8:30       ` Sergey Bronnikov via Tarantool-patches
2023-10-10  8:57   ` Sergey Kaplun via Tarantool-patches
2023-10-13 11:50     ` Maxim Kokryashkin via Tarantool-patches
2023-10-22  1:58       ` Sergey Kaplun via Tarantool-patches
2023-11-07 13:31 ` [Tarantool-patches] [PATCH luajit v2 0/5] Fix error-throwing on an incorrect coroutine Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a861ad27810eab2c5fd5bc659027b5a57f6577f.1695968227.git.m.kokryashkin@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v2 3/5] Revert "arm64: fix cur_L restoration on error throw"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox