From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CB308741E8; Fri, 6 Aug 2021 02:47:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CB308741E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628207260; bh=YvSKwVOImezZInWQBcD6bJcrrsgMWoELWKZZZ3K9BwA=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=OHpOBjoPnM5XGLjUewyFeeEy7VTGul338vQgHu6utKZGQO8yVrvbBW83uJct78utw +s58U6vhkcE376gPjIT4vugMX1pIgjsgvwcZcowAykvqw+AqNHJJTHz72joNwWq19+ 1JSGjG92CkXq1yACi/UugeuPjbCzJssDww8DvuhM= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6A9AD741E7 for ; Fri, 6 Aug 2021 02:47:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6A9AD741E7 Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1mBn5O-0006ig-Vv for tarantool-patches@dev.tarantool.org; Fri, 06 Aug 2021 02:47:39 +0300 To: tarantool-patches@dev.tarantool.org References: Message-ID: <6a5fb260-814a-6556-3e16-cbca3fd4429c@tarantool.org> Date: Fri, 6 Aug 2021 02:47:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9ECFD080E047A606F6525B29142351271182A05F538085040FEE9BE99FA5B545B59AE818CC0C40AF82ACB7704FF37982B3ECED6936A10A741 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DECE8D0A5E25C0FCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF58BB58AE3180708638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86F1890E32C4A47633E41CD10BE3BAFF2117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC8105B04EFE076281421F57CABF51D54D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD74539164518AE5040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637AD0424077D726551EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D94463893BF8742D021AFD13EC734898E X-C1DE0DAB: 0D63561A33F958A5B904B454057FBA2CDD4833E13EBFDDA4E1668FC03982625FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347D10A9FCB2A62DFED605C101100D55952FAA693297565ABC9751DE3377E8507FB933F782D36326D51D7E09C32AA3244CEFF55F1CFB5FB19C3648EF84101489E760759606DA2E136A3EB3F6AD6EA9203E X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFhlvmGwdUwRW4fZjxUtaZg== X-Mailru-Sender: 5C3750E245F362008BC1685FEC6306EDED8A760E22BA5A9159AE818CC0C40AF8CA71892AC981DD5F5105BD0848736F9966FEC6BF5C9C28D97E07721503EA2E00ED97202A5A4E92BF7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 6/7] sql: remove implicit cast from OP_MustBeInt X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" I dropped this patch since I decided not to drop "precise" functions. On 28.07.2021 23:51, Mergen Imeev via Tarantool-patches wrote: > This patch removes implicit casting from STRING to number in > OP_MustBeInt opcode. > > Part of #4470 > --- > src/box/sql/vdbe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > index 81551acf3..89e77baee 100644 > --- a/src/box/sql/vdbe.c > +++ b/src/box/sql/vdbe.c > @@ -1435,7 +1435,8 @@ case OP_AddImm: { /* in1 */ > */ > case OP_MustBeInt: { /* jump, in1 */ > pIn1 = &aMem[pOp->p1]; > - if (mem_to_int_precise(pIn1) != 0) { > + enum field_type type = FIELD_TYPE_INTEGER; > + if (!mem_is_num(pIn1) || mem_cast_implicit_number(pIn1, type) != 0) { > if (pOp->p2 != 0) > goto jump_to_p2; > diag_set(ClientError, ER_SQL_TYPE_MISMATCH,