From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 516E5469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 02:44:36 +0300 (MSK)
References: <cover.1601729099.git.korablev@tarantool.org>
 <0a5e175c-aeb1-a847-ebca-ba5cdbaaca11@tarantool.org>
 <20201013101839.GA18306@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <6a552158-6152-10b8-7f86-47aa71923ed4@tarantool.org>
Date: Thu, 15 Oct 2020 01:44:34 +0200
MIME-Version: 1.0
In-Reply-To: <20201013101839.GA18306@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert
	operation
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

The test looks fine, but hard to extend. I would better try to
organize a more extendible folder structure, like test/xlog/upgrade
does. With the current 'flat' structure we will have problems with
adding more tests for other versions in the future.

I see you already pushed it, so I am too late.