From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 143956F852; Tue, 16 Nov 2021 00:56:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 143956F852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1637013383; bh=fdZsLtvQyxH1WZ40/FSFMsA/gBkVtU6NwBrL6iJM+UA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=uGFE9Uxw+vSL45aHR87j2WfiL3PJbkzBUTZc05zQ75pF8jzgTrBYSCK0zDNHmXX5Z e16FlUguNvFNqxkwugVqEkLnBY7QCy0C8Dn1THr8iFdgFANKBJIuhJKDlYTctvMwqR lJt41ew/PtSCb5hh8shDNi60BNy9/S/Yim+XvGpg= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 519AD6F852 for ; Tue, 16 Nov 2021 00:56:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 519AD6F852 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1mmjxc-00069e-FR; Tue, 16 Nov 2021 00:56:20 +0300 Message-ID: <6a38283a-1fa3-f2f3-a085-cfa6ca81fb72@tarantool.org> Date: Mon, 15 Nov 2021 22:56:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Content-Language: en-US To: Serge Petrenko , tarantool-patches@dev.tarantool.org References: <225fd821-26be-3afb-3ec5-c0b33487c5a1@tarantool.org> <76dcc21e-0518-b5ef-4b10-e7c8578e505a@tarantool.org> In-Reply-To: <76dcc21e-0518-b5ef-4b10-e7c8578e505a@tarantool.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9731B3922EC063979CAB00300CDA98DC51CCA794E1CC6B18A00894C459B0CD1B931EABB75F28F71E1D19672007315D287AF4A93A166873B141F641D77257F6382 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375121C8F3070B83748638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88E3D71FE4FE43C1C309F1A8FD2CF9A1A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4B4782AAF36435267CD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3568FCE88E0C8489DAD7EC71F1DB88427C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637AD0424077D726551EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505821664390928D2CFE469006DEA42ADD7 X-C1DE0DAB: 0D63561A33F958A591ABD3655952E3A90A62812E3E74DCAC5CFF1638408E1373D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754E2A133C74F7AB4F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3450C5E6D685282BA1BABE0FD32B52D1DD1698598D1513AAE09C0DAAEA5C4A84F57D0EA0EC0967D0711D7E09C32AA3244C0A2D011036A2824444F16BD5D4C97A88A95CA90A1D8AC565729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojTPuBkNIN61GrnsGm2h1JIA== X-Mailru-Sender: A897EC63681333B63B4725CD42BE27D2358C83221E8D11533918A116BD1BADEAF1E90838FFE501F57B4F2DF44667E230E66B5C1DBFD5D09D245155DCEF7B7CF8F7F907C8983C07697402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 10/11] box: enrich ER_READONLY with new details X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" > Thanks for the changes! > > One final note: > I propose to move box_ro_reason() from the last commit here and use it > when setting error reason, so that error.reason would be the same as > box.info.ro_reason. I added more details to error message than to ro_reason because when you see ro_reason, you can go and check other fields of box.info for details. When you have only an error object, and what is worse - it is cast to a string during packing, you don't have a place to look up the details already. Thus I wanted the error object to be self-sufficient. Even if it degrades to a simple string during marshaling.