From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DD53323F09
	for <tarantool-patches@freelists.org>; Wed,  9 Jan 2019 07:29:48 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id hGZ61EcneEag for <tarantool-patches@freelists.org>;
	Wed,  9 Jan 2019 07:29:48 -0500 (EST)
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9BCCC21A27
	for <tarantool-patches@freelists.org>; Wed,  9 Jan 2019 07:29:48 -0500 (EST)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: [tarantool-patches] Re: [PATCH v2 4/5] sql: encode tuples with
 mpstream on Vdbe run
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <7a90ee7f-9180-a00e-8f99-129e2edf2735@tarantool.org>
Date: Wed, 9 Jan 2019 14:29:45 +0200
Content-Transfer-Encoding: 7bit
Message-Id: <6FBA93B2-642C-4D19-B3E0-1257BA6C73AF@tarantool.org>
References: <cover.1546079994.git.kshcherbatov@tarantool.org>
 <d5cdf182b5a828dbe0a0a78d5560e1329c671038.1546079994.git.kshcherbatov@tarantool.org>
 <F7CB9952-CC4B-43B3-BEEC-240C5D8056DF@tarantool.org>
 <7a90ee7f-9180-a00e-8f99-129e2edf2735@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>


>> Lets replace these if-else's with one switch.
> Unfortunately, it is not possible now, as we may have a flag combination
> (like OP_String+OP_Blob). You may take a look into Server chat for more
> details for this particular case, but it is not the one.
> Maybe we may improve it in future(when affinity would be reworked?) but
> not now and not as a part of this patch, I believe.

It looks like an issue. I am going to open an issue then and fix it.
Thx for investigation.

Whole patchset LGTM.