From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 27B3E273CD for ; Thu, 22 Aug 2019 09:04:14 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Go1ZZ93PLsqQ for ; Thu, 22 Aug 2019 09:04:14 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D722B273CA for ; Thu, 22 Aug 2019 09:04:13 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH v4 1/4] sql: rename sql_vdbe_mem_alloc_region helper From: "n.pettik" In-Reply-To: <28f5c2fe5c21b2d58329911cb420aa5f10949051.1566400979.git.kshcherbatov@tarantool.org> Date: Thu, 22 Aug 2019 16:04:11 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <6AEDFFFA-FACD-4002-B577-E3CF7D277657@tarantool.org> References: <28f5c2fe5c21b2d58329911cb420aa5f10949051.1566400979.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov > On 21 Aug 2019, at 18:28, Kirill Shcherbatov = wrote: >=20 > Changed sql_vdbe_mem_alloc_region routine name to the > sql_vdbe_mem_alloc_blob_region because we are going to introduce > a new function with a really similar (but more appropriate) name > vdbemem_alloc_on_region in following patch. >=20 > Needed for #2200, #4113, #2233 > --- > src/box/sql/vdbe.h | 2 +- > src/box/sql/vdbe.c | 2 +- > src/box/sql/vdbeaux.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/src/box/sql/vdbe.h b/src/box/sql/vdbe.h > index 8f16202ba..e5a85fe0e 100644 > --- a/src/box/sql/vdbe.h > +++ b/src/box/sql/vdbe.h > @@ -278,7 +278,7 @@ int sqlVdbeRecordCompare(struct sql *db, int = key_count, > const void *key1, UnpackedRecord *key2); > UnpackedRecord *sqlVdbeAllocUnpackedRecord(struct sql *, > struct key_def *); > -int sql_vdbe_mem_alloc_region(Mem *, uint32_t); > +int sql_vdbe_mem_alloc_blob_region(Mem *, uint32_t); You can also remove =E2=80=99sql=E2=80=99 prefix (vdbe_ prefix implies = that namespace is related to sql) and make it static.