From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 24C6822E6D for ; Mon, 22 Jul 2019 06:48:57 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aKYaHfyCClO1 for ; Mon, 22 Jul 2019 06:48:57 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D1C5E22E12 for ; Mon, 22 Jul 2019 06:48:47 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH v4 4/4] sql: do not increase row-count if INSERT or REPLACE failed From: "n.pettik" In-Reply-To: <20190719093650.GB22697@tarantool.org> Date: Mon, 22 Jul 2019 13:48:44 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <6AE2D6A3-B992-4BBC-9BE7-6A064F316E66@tarantool.org> References: <1C2735EE-5E20-43D6-B8BA-3B83C7B54482@tarantool.org> <20190719093650.GB22697@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen I=E2=80=99ve force pushed a couple of cosmetic fixes. Also added check of return value of vdbe_add_new_autoinc_id() - it can fail due to OOM. Now LGTM.