From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH v3 3/7] box: move offset_slot init to tuple_format_add_field References: <60775a575969680c7ee61e88bb1bb0a3ae95bd7a.1554218695.git.kshcherbatov@tarantool.org> <20190404061944.GC1116@chai> From: Kirill Shcherbatov Message-ID: <697b2d95-ed98-7b6e-09a9-621fcc2d6d9d@tarantool.org> Date: Fri, 5 Apr 2019 20:17:29 +0300 MIME-Version: 1.0 In-Reply-To: <20190404061944.GC1116@chai> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Konstantin Osipov Cc: vdavydov.dev@gmail.com List-ID: > I actually had a nit about this patch, I think 3 goto labels in > such a simple function is a bit of an overkill - the code is > harder to follow than necessary. I would ditch the 'cleanup' > label, this would make the code simpler Hi! Ok! I'll try to fix it with central patch that would touch this code region. I will deal with the last patch fixes one week later, after vacation. After investigation the causes of degradation on SQL tests conducted by Alexander, I think we can not worry about initializing the field map and concentrate on featured tuple_format_iterator.