From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2F06E21196 for ; Mon, 10 Dec 2018 09:17:49 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WMScZncJ_oOu for ; Mon, 10 Dec 2018 09:17:49 -0500 (EST) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DF46A20237 for ; Mon, 10 Dec 2018 09:17:48 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH 4/6] sql: don't add string of 'CREATE TABLE...' to space opts References: <8d774a673688db0503e67b05be1ece319bfd9ea4.1544387419.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: <6965549c-a919-0460-2603-b4765a32e338@tarantool.org> Date: Mon, 10 Dec 2018 17:17:46 +0300 MIME-Version: 1.0 In-Reply-To: <8d774a673688db0503e67b05be1ece319bfd9ea4.1544387419.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik Thanks for the patch! See 1 comment and review fixes below. On 10/12/2018 00:30, Nikita Pettik wrote: > We don't rely no more on this string anymore and it can be removed for 'no more on this anymore' - please, rephrase. Sounds a little tautological. > ordinary tables. However, it is still used to hold SELECT body for view. > > Part of #2647 > --- > src/box/sql.c | 8 +- > src/box/sql/analyze.c | 2 +- > src/box/sql/build.c | 242 ++---------------------------------------------- > src/box/sql/pragma.c | 2 - > src/box/sql/sqliteInt.h | 1 - > test/sql/upgrade.result | 8 +- > test/sql/view.result | 3 + > test/sql/view.test.lua | 1 + > 8 files changed, 19 insertions(+), 248 deletions(-) > My review fix here and on the branch: ==================================================================== commit e4ea3a20c71e73426a9ea2478b55c346b0ca3a41 Author: Vladislav Shpilevoy Date: Mon Dec 10 16:57:18 2018 +0300 Review fix diff --git a/src/box/sql/pragma.c b/src/box/sql/pragma.c index 325c272b0..ce1f4aed7 100644 --- a/src/box/sql/pragma.c +++ b/src/box/sql/pragma.c @@ -294,7 +294,7 @@ sql_pragma_table_info(struct Parse *parse, const char *tbl_name) static int sql_pragma_table_stats(struct space *space, void *data) { - if (space->def->opts.sql == NULL || space->def->opts.is_view) + if (space->def->opts.is_view) return 0; struct Parse *parse = (struct Parse *) data; struct index *pk = space_index(space, 0);