From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 687A7469719 for ; Wed, 7 Oct 2020 16:53:15 +0300 (MSK) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) From: Roman Khabibov In-Reply-To: Date: Wed, 7 Oct 2020 16:53:14 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <69305126-34BC-41B8-B209-4D7C3BE30BC2@tarantool.org> References: <20200911215115.6622-1-roman.habibov@tarantool.org> <20200911215115.6622-3-roman.habibov@tarantool.org> <36bb1beb-a59a-57d9-a1ef-c0ef5af49d35@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 2/6] sql: refactor create_table_def and parse List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the review. > On Oct 6, 2020, at 00:22, Vladislav Shpilevoy = wrote: >=20 > Hi! Thanks for the patch! >=20 >> diff --git a/src/box/sql/parse_def.h b/src/box/sql/parse_def.h >> index cb0ecd2fc..21829b6f0 100644 >> --- a/src/box/sql/parse_def.h >> +++ b/src/box/sql/parse_def.h >> @@ -500,12 +505,12 @@ create_view_def_init(struct create_view_def = *view_def, struct Token *name, >> } >>=20 >> static inline void >> -create_table_def_destroy(struct create_table_def *table_def) >> +create_fkeys_def_destroy(struct create_fkeys_def *fkeys_def) >=20 > Where is create_checks_def destroyed? There's nothing to destroy in create_checks_def. Or is it worth creating it to keep the formality?=