From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0FC64F545A7; Fri, 30 Aug 2024 10:25:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0FC64F545A7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1725002730; bh=+B29dJbKw5jHiOoEUlWibUJwawgK7EIwav4CR8wOo/w=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nCtkUI8JjLtXJvTt1YtovfIbsNE6bFtqTTNCclMYf/RCjISqHnsYAOc47IjP6Q7xR K8HaFgOeMWDJ6y0HaZbPm+CfbT04JAy8fyAE690Bz6p5UzVJyh5Eo6Y+/6HRP7TAkO XHsD1k5OyTIP1FvqDcUwzShHdiRLSYWab2XVmPPg= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [95.163.41.91]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B8C36F54580 for ; Fri, 30 Aug 2024 10:25:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B8C36F54580 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1sjw0d-0000000FVc3-36pR; Fri, 30 Aug 2024 10:25:28 +0300 Content-Type: multipart/alternative; boundary="------------sq0hpUQiJ1ff1YF1Wl0EX25G" Message-ID: <690e157e-5908-43e6-8f43-b1ca7c26179c@tarantool.org> Date: Fri, 30 Aug 2024 10:25:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <43b0a69113d3f42a49fa42fea34516561f5ca8a7.1723638851.git.skaplun@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9FD9EA36614B763B61CA3C4EE7186AFED65D574DAB7763987182A05F5380850404C228DA9ACA6FE27F99578751AAAC7BF411046492FDDF806FCAD9EB17F0872D542BCA91FC9B95281903EDB4B0951EB1E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A8325FA649D0A450EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637645995A778B1BFFAEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F3608604886B179537226760597CE6979E3A2863476CE081C81A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE76937630EBE596648D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C079D735746F6000DBCD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67A7B0CDC955A1711089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A57713677C6F7A977C5002B1117B3ED696F12DF297C5E44532BFF4097FFC9E796F823CB91A9FED034534781492E4B8EEAD69BF13FED57427F1BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3455AC8BF8E3153BA00F8E8BF5F4D88DCD83F18F3B8D4A9FDE7591F5EAD800F6FC070453A1E9DDAD5A1D7E09C32AA3244C4893C652D63084A17215182CA7F28860ED4045BD1C624C8BEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQYgdG78G+s2P4HqLfuEjCQ== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140644650813B07F8C484DB6FE4A8249ACBD72FD8C344CFE3B30152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 02/36] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------sq0hpUQiJ1ff1YF1Wl0EX25G Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, On 15.08.2024 16:31, Sergey Kaplun wrote: > Sergey, > > On 15.08.24, Sergey Bronnikov wrote: >> Hi, Sergey >> >> Thanks for the patch! See my comments below. >> >> On 14.08.2024 16:55, Sergey Kaplun wrote: >>> This patch moves the test from the to the >>> created directory, includes it in , and names subtests. >>> >>> Testing optimizations in requires CSE, DCE, FOLD, and FWD >>> optimizations enabled. Hence, the corresponding flags are used for the >>> directory in . >> It is still unclear for me *why* a reason of this change. The main idea behind the patch is "getting rid of suite". > The tests for other optimizations also require the necessary flags, see > . Also, I don't understand what *change* you mean -- it is > enabling of test, not changing its functionality. > > > --------------sq0hpUQiJ1ff1YF1Wl0EX25G Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

On 15.08.2024 16:31, Sergey Kaplun wrote:
Sergey,

On 15.08.24, Sergey Bronnikov wrote:

Hi, Sergey

Thanks for the patch! See my comments below.

On 14.08.2024 16:55, Sergey Kaplun wrote:

This patch moves the <alias_alloc.lua> test from the <misc> to the
created <opt/mem> directory, includes it in <index>, and names subtests.

Testing optimizations in <lj_opt_mem.c> requires CSE, DCE, FOLD, and FWD
optimizations enabled. Hence, the corresponding flags are used for the
<mem> directory in <index>.

It is still unclear for me *why* a reason of this change.
The main idea behind the patch is "getting rid of <misc> suite".
The tests for other optimizations also require the necessary flags, see
<index>. Also, I don't understand what *change* you mean -- it is
enabling of test, not changing its functionality.



      

      
<snipped>



    

  
  


--------------sq0hpUQiJ1ff1YF1Wl0EX25G--