From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DC0F42C1D1 for ; Wed, 24 Apr 2019 16:23:18 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WPEy0Z4c4UkO for ; Wed, 24 Apr 2019 16:23:18 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 993C52C19F for ; Wed, 24 Apr 2019 16:23:18 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 4/6] swim: wrap sio_strfaddr() References: <73ba32c413ce9371b845ac161a0d5ea698fac575.1556116199.git.v.shpilevoy@tarantool.org> <20190424164039.GD13687@atlas> From: Vladislav Shpilevoy Message-ID: <68d992e3-e92f-680c-73a3-eb2e5ad1f6b3@tarantool.org> Date: Wed, 24 Apr 2019 23:23:16 +0300 MIME-Version: 1.0 In-Reply-To: <20190424164039.GD13687@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Konstantin Osipov On 24/04/2019 19:40, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/04/24 18:50]: >> SIO provides a function sio_strfaddr() to obtain string >> representation of arbitrary struct sockaddr. And it uses >> singleton buffer to store results, because some of them can't >> fit into tt_static_buf() according to POSIX name limits. > > This is minor, but I would make sio_strfaddr() use the same set of > buffers as provided by tt_static_buf() instead, with a static > assert that the buffer size is large enough. As I said, the tt_static_buf is not big enough. SIO uses NI_MAXHOST constant which on Linux is 1025 > size of tt_static_buf. http://man7.org/linux/man-pages/man3/getnameinfo.3.html If you still think we will not break anything, I can do that. Just confirm that you are sure. It will not eliminate swim_inaddr_str() though, because most of the problems were about huge cast to 'const struct sockaddr *' and passing sizeof(struct sockaddr_in) each time - it made code unreadable. > >> SWIM uses only AF_INET addresses, they are short enough to fit >> into tt_static_buf(). Also SWIM is going to call sio_strfaddr() >> on more than 1 address in a row in subsequent patches, and >> singleton buffer does not work here - each call will overwrite >> result of the previous. Besides, SWIM never uses struct sockaddr >> type. All these reasons are sufficient to wrap sio_strfaddr() >> with encapsulated cast to struct sockaddr *, and copying on >> tt_static_buf(). >> > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >